Skip to content

Conversation

@t-indumathy
Copy link

@t-indumathy t-indumathy commented Aug 28, 2023

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 28, 2023

CLA assistant check
All committers have signed the CLA.

@t-indumathy t-indumathy marked this pull request as draft August 28, 2023 07:18
@t-indumathy t-indumathy marked this pull request as ready for review August 28, 2023 10:03
@tombuildsstuff
Copy link
Contributor

hey @t-indumathy

Thanks for this PR.

Unfortunately there's a few issues with the Swagger definitions for both SQL and Synapse which are preventing us from importing these Services at present - the issue tracking that on our side can be found here, and on the Azure/azure-rest-api-specs repository can be found here.

At the moment unfortunately these issues are preventing us from importing these API versions, so we're unable to merge this PR at this time, however once the issues in this comment have been addressed by the Service Team then we should be able to get this version imported/PR merged pretty quickly.

Thanks!

@tombuildsstuff tombuildsstuff added data/swagger-issue An issue related to the Swagger/OpenAPI Definitions upstream/swagger-issue-raised An issue has been opened for this issue on the `Azure/azure-rest-api-specs` repository labels Sep 4, 2023
tombuildsstuff added a commit that referenced this pull request Oct 25, 2023
This is possible now that Azure/azure-rest-api-specs#26303 and
#3203 have been merged

Fixes #2842
Supersedes #2988
@tombuildsstuff
Copy link
Contributor

hey @t-indumathy

Thanks again for this PR - the upstream issue blocking this one has since been resolved, as such I've opened #3234 which adds the latest version (2023-02-01-preview) of the SQL API which supports SQL Managed Instance Threat Protection. Since #3234 contains a newer API Version than in this PR, whilst I'd like to thank you for this contribution I'm going to close this PR in favour of #3234 which has since been merged - and should be regenerated into hashicorp/go-azure-sdk shortly.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data/swagger-issue An issue related to the Swagger/OpenAPI Definitions upstream/swagger-issue-raised An issue has been opened for this issue on the `Azure/azure-rest-api-specs` repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants