remove inline sig

Author: dsa0x

internal/terraform/node_resource_abstract_instance.go

@@ -231,7 +231,7 @@ func (n *NodeAbstractResourceInstance) preApplyHook(ctx EvalContext, change *pla
 }
 
 // postApplyHook calls the post-Apply hook
-func (n *NodeAbstractResourceInstance) postApplyHook(ctx EvalContext, action plans.Action, state *states.ResourceInstanceObject, priorState cty.Value, err error) tfdiags.Diagnostics {
+func (n *NodeAbstractResourceInstance) postApplyHook(ctx EvalContext, state *states.ResourceInstanceObject, err error) tfdiags.Diagnostics {
 	var diags tfdiags.Diagnostics
 
 	// Only managed resources have user-visible apply actions.

internal/terraform/node_resource_apply_instance.go

@@ -387,7 +387,7 @@ func (n *NodeApplyableResourceInstance) managedResourceExecute(ctx EvalContext)
 		}
 	}
 
-	diags = diags.Append(n.postApplyHook(ctx, diffApply.Action, state, diffApply.Change.Before, diags.Err()))
+	diags = diags.Append(n.postApplyHook(ctx, state, diags.Err()))
 	diags = diags.Append(updateStateHook(ctx))
 
 	// Post-conditions might block further progress. We intentionally do this

internal/terraform/node_resource_destroy.go

@@ -204,7 +204,7 @@ func (n *NodeDestroyResourceInstance) managedResourceExecute(ctx EvalContext) (d
 		if diags.HasErrors() {
 			// If we have a provisioning error, then we just call
 			// the post-apply hook now.
-			diags = diags.Append(n.postApplyHook(ctx, plans.Delete, state, changeApply.Change.Before, diags.Err()))
+			diags = diags.Append(n.postApplyHook(ctx, state, diags.Err()))
 			return diags
 		}
 	}
@@ -223,7 +223,7 @@ func (n *NodeDestroyResourceInstance) managedResourceExecute(ctx EvalContext) (d
 	}
 
 	// create the err value for postApplyHook
-	diags = diags.Append(n.postApplyHook(ctx, changeApply.Action, state, changeApply.Change.Before, diags.Err()))
+	diags = diags.Append(n.postApplyHook(ctx, state, diags.Err()))
 	diags = diags.Append(updateStateHook(ctx))
 	return diags
 }

internal/terraform/node_resource_destroy_deposed.go

@@ -326,7 +326,7 @@ func (n *NodeDestroyDeposedResourceInstanceObject) Execute(ctx EvalContext, op w
 		return diags
 	}
 
-	diags = diags.Append(n.postApplyHook(ctx, change.Action, state, change.Change.Before, diags.Err()))
+	diags = diags.Append(n.postApplyHook(ctx, state, diags.Err()))
 
 	return diags.Append(updateStateHook(ctx))
 }

internal/terraform/node_resource_plan.go

@@ -373,7 +373,6 @@ func (n *nodeExpandPlannableResource) dynamicExpand(ctx EvalContext, moduleInsta
 
 	orphans := n.findOrphans(ctx, moduleInstances)
 
-	// TODO: orphaned resource instances too?
 	for _, res := range orphans {
 		for key := range res.Instances {
 			addr := res.Addr.Instance(key)