Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-core servant packages for for GHC 8.10 #1331

Open
domenkozar opened this issue Aug 19, 2020 · 20 comments
Open

non-core servant packages for for GHC 8.10 #1331

domenkozar opened this issue Aug 19, 2020 · 20 comments
Assignees

Comments

@domenkozar
Copy link
Contributor

domenkozar commented Aug 19, 2020

@fisx @arianvp @dmjio

@domenkozar
Copy link
Contributor Author

same for servant-swagger

@arianvp
Copy link
Member

arianvp commented Aug 20, 2020

cc @fisx I thought we got those to work already?

@arianvp
Copy link
Member

arianvp commented Aug 20, 2020

(I edited your above comment to tag the current maintainers)

@domenkozar
Copy link
Contributor Author

Refs #1325

@domenkozar
Copy link
Contributor Author

🙏

@arianvp
Copy link
Member

arianvp commented Aug 24, 2020

This just needs an upload. That's it: http://hackage.haskell.org/package/servant-conduit

@fisx could you pair with me on this tomorrow? I never did a hackage upload before :)

@domenkozar
Copy link
Contributor Author

@domenkozar
Copy link
Contributor Author

Same for servant-docs.

This is now blocking servant-auth releases.

@arianvp
Copy link
Member

arianvp commented Aug 25, 2020

I tried to do it but my hackage account doesn't seem to have enough rights. This is blocked on me getting a hold of @fisx (which shouldn't be too hard as we share an office). I'm working on it :)

@domenkozar domenkozar changed the title servant-conduit for GHC 8.10 servant-{conduit,swagger,docs} for GHC 8.10 Aug 25, 2020
@fisx
Copy link
Member

fisx commented Aug 26, 2020

I tried to do it but my hackage account doesn't seem to have enough rights. This is blocked on me getting a hold of @fisx (which shouldn't be too hard as we share an office). I'm working on it :)

i've added you.

i wonder if there is an easy way to find all servant projects' maintainers lists?

@fisx
Copy link
Member

fisx commented Aug 26, 2020

@domenkozar
Copy link
Contributor Author

@arianvp any luck? :)

@fisx
Copy link
Member

fisx commented Sep 1, 2020

(forgot swagger, i'll do that next.)

@domenkozar
Copy link
Contributor Author

I use https://github.com/domenkozar/releaser to automate releases

@fisx
Copy link
Member

fisx commented Sep 1, 2020

(forgot swagger, i'll do that next.)

https://hackage.haskell.org/package/servant-swagger-1.1.10

@arianvp arianvp changed the title servant-{conduit,swagger,docs} for GHC 8.10 non-core servant packages for for GHC 8.10 Oct 12, 2020
@arianvp
Copy link
Member

arianvp commented Oct 12, 2020

Many of the above packages don't have their CI updated yet to run against GHC 8.10. as they live in a separate repo. We should fix that first. Just a matter of adjusting parameters; and running haskell-ci to generate the new .travis.yml , hoping there are no failures, and then pushing the release to hackage.

@fisx
Copy link
Member

fisx commented Oct 13, 2020

this is too much manual work...

@arianvp
Copy link
Member

arianvp commented Oct 25, 2020

I've updated the checklist above. All the packages that aren't checked off are currently broken on 8.10 and require fixing + release.

The ones that have been ticked off have working CI but still need a release to have a valid build plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants