Revert "Do not backup add-on being uninstalled (home-assistant#5917)" (home-assistant#5925)

This reverts commit 63fde3b.

This change introduced another more severe regression, causing all
add-ons that haven't been started since Supervisor startup to cause
errors during their backup. More sophisticated check would have to be
implemented to address edge cases during backups for non-existing
add-ons (or their config actually).

Fixes home-assistant#5924

Author: sairon

supervisor/addons/addon.py

@@ -1335,13 +1335,6 @@ def _addon_backup(
 
         wait_for_start: asyncio.Task | None = None
 
-        # Refuse to backup if add-on is unknown (e.g. has been uninstalled by the user
-        # since the backup got started).
-        if self.state == AddonState.UNKNOWN:
-            raise AddonsError(
-                f"Add-on {self.slug} is not installed, cannot backup!", _LOGGER.error
-            )
-
         data = {
             ATTR_USER: self.persist,
             ATTR_SYSTEM: self.data,

tests/addons/test_addon.py

@@ -102,7 +102,7 @@ async def test_addon_state_listener(coresys: CoreSys, install_addon_ssh: Addon)
     with patch.object(DockerAddon, "attach"):
         await install_addon_ssh.load()
 
-    assert install_addon_ssh.state == AddonState.STOPPED
+    assert install_addon_ssh.state == AddonState.UNKNOWN
 
     with patch.object(Addon, "watchdog_container"):
         _fire_test_event(coresys, f"addon_{TEST_ADDON_SLUG}", ContainerState.RUNNING)

tests/conftest.py

@@ -40,7 +40,6 @@
     ATTR_TYPE,
     ATTR_VERSION,
     REQUEST_FROM,
-    AddonState,
     CoreState,
 )
 from supervisor.coresys import CoreSys
@@ -632,7 +631,6 @@ async def install_addon_ssh(coresys: CoreSys, repository):
     coresys.addons.data._data = coresys.addons.data._schema(coresys.addons.data._data)
 
     addon = Addon(coresys, store.slug)
-    addon.state = AddonState.STOPPED
     coresys.addons.local[addon.slug] = addon
     yield addon
 
@@ -645,7 +643,6 @@ async def install_addon_example(coresys: CoreSys, repository):
     coresys.addons.data._data = coresys.addons.data._schema(coresys.addons.data._data)
 
     addon = Addon(coresys, store.slug)
-    addon.state = AddonState.STOPPED
     coresys.addons.local[addon.slug] = addon
     yield addon