Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple destinations in make_uri and parse_uri [$350] #83

Open
woodser opened this issue May 20, 2021 · 12 comments
Open

Support multiple destinations in make_uri and parse_uri [$350] #83

woodser opened this issue May 20, 2021 · 12 comments
Assignees
Labels
a:monero Changes related to Monero 💰bounty There is a bounty on this issue is:feature Request for a new feature P4 Scheduled task, but low priority

Comments

@woodser
Copy link
Contributor

woodser commented May 20, 2021

This issue requests supporting multiple addresses and amounts in monero-wallet-rpc's make_uri and parse_uri.

This will be used to deposit 2 outputs to the Haveno wallet, one to cover the deposit amount and one to cover the trade fee, in order to allow trades to be posted and taken once funds are available.

See monero-project/monero#7731

@erciccione erciccione added a:monero Changes related to Monero is:feature Request for a new feature labels May 20, 2021
@erciccione erciccione changed the title Support multiple destinations in make_uri and parse_uri Support multiple destinations in make_uri and parse_uri [$500] May 25, 2021
@erciccione erciccione added the 💰bounty There is a bounty on this issue label May 25, 2021
@github-actions
Copy link

There is a bounty on this issue, the amount is in the title. The bounty will be awarded to the first person(s) who resolves this issue. Read the full conditions in the 'bounties.md' file. If you are starting to work on this issue, please write a comment here, so that we can assign the issue to you and avoid duplicated work.

@benevanoff
Copy link

I am beginning work on this now

@erciccione
Copy link
Contributor

Thanks @benevanoff. Please use #haveno-dev on matrix or freenode for questions and coordination :)

@woodser
Copy link
Contributor Author

woodser commented Jun 2, 2021

Note multi-output deposits are no longer needed with the new trade protocol, but we will honor the bounty once merged into monero-project.

@erciccione erciccione added the P3 normal priority label Oct 28, 2021
@erciccione erciccione added P4 Scheduled task, but low priority and removed P3 normal priority labels Nov 9, 2021
@woodser woodser changed the title Support multiple destinations in make_uri and parse_uri [$500] Support multiple destinations in make_uri and parse_uri [2 XMR] Dec 2, 2022
@woodser woodser changed the title Support multiple destinations in make_uri and parse_uri [2 XMR] Support multiple destinations in make_uri and parse_uri [$350] Dec 2, 2022
@NorrinRadd
Copy link

@woodser is this still open?

@woodser
Copy link
Contributor Author

woodser commented Apr 6, 2024

Yes this has not been completed. A PR was submitted to monero-project but never merged.

@NorrinRadd
Copy link

Ok, I will take it @woodser

@U65535F
Copy link

U65535F commented Jan 26, 2025

It's been a long time since the assignment and it hasn't completed yet? Is this still being worked on?

@woodser
Copy link
Contributor Author

woodser commented Jan 26, 2025

The previous solution in progress was deleted from the monero-project repo somehow, so this issue is still available for someone to complete.

@U65535F
Copy link

U65535F commented Feb 2, 2025

@woodser I am actively working on this thing. Check PR 9756 on monero code base. Check if it meets the requirements.

@woodser
Copy link
Contributor Author

woodser commented Feb 2, 2025

Linking to the PR for reference: monero-project/monero#9756

@U65535F
Copy link

U65535F commented Feb 3, 2025

Linking to the PR for reference

@woodser Could you have a look at the code and see if it actually meets all of your requirements? Any suggestions would be appreciated. The mods are taking a while to respond (totally okay, it's not their job so obviously they don't fully dedicate their time in the repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:monero Changes related to Monero 💰bounty There is a bounty on this issue is:feature Request for a new feature P4 Scheduled task, but low priority
Projects
None yet
Development

No branches or pull requests

6 participants
@NorrinRadd @woodser @erciccione @benevanoff @U65535F and others