Skip to content

Commit 1e7ab6c

Browse files
authored
Fixed compatibility tests (#681)
Fixed compatibility tests, use current_thread instead of deprecated currentThread.
1 parent 5df2d8e commit 1e7ab6c

File tree

6 files changed

+13
-6
lines changed

6 files changed

+13
-6
lines changed

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ check:
55
black --check --config black.toml .
66

77
test:
8+
pytest -m "not enterprise"
9+
10+
test-enterprise:
811
pytest
912

1013
test-cover:

hazelcast/util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def current_time_in_millis():
5555

5656

5757
def thread_id():
58-
return threading.currentThread().ident
58+
return threading.current_thread().ident
5959

6060

6161
def to_millis(seconds):

tests/integration/backward_compatible/proxy/vector_collection_test.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ def test_size(self):
168168
self.vector_collection.clear()
169169
self.assertEqual(self.vector_collection.size(), 0)
170170

171-
def assert_document_equal(self, doc1: Document, doc2: Document) -> None:
171+
def assert_document_equal(self, doc1, doc2) -> None:
172172
self.assertEqual(doc1.value, doc2.value)
173173
self.assertEqual(len(doc1.vectors), len(doc2.vectors))
174174
# currently there's a bug on the server-side about vector names.
@@ -179,7 +179,7 @@ def assert_document_equal(self, doc1: Document, doc2: Document) -> None:
179179
for i in range(len(doc1.vectors)):
180180
self.assert_vector_equal(doc1.vectors[i], doc2.vectors[i], skip_check_name)
181181

182-
def assert_vector_equal(self, vec1: Vector, vec2: Vector, skip_check_name=False):
182+
def assert_vector_equal(self, vec1, vec2, skip_check_name=False):
183183
if not skip_check_name:
184184
self.assertEqual(vec1.name, vec2.name)
185185
self.assertEqual(vec1.type, vec2.type)
@@ -188,9 +188,9 @@ def assert_vector_equal(self, vec1: Vector, vec2: Vector, skip_check_name=False)
188188
self.assertAlmostEqual(vec1.vector[i], vec2.vector[i])
189189

190190
@classmethod
191-
def vec1(cls, elems) -> Vector:
191+
def vec1(cls, elems):
192192
return Vector("vector", Type.DENSE, elems)
193193

194194
@classmethod
195-
def doc1(cls, value, vector_elems) -> Document:
195+
def doc1(cls, value, vector_elems):
196196
return Document(value, cls.vec1(vector_elems))

tests/integration/backward_compatible/threading_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ def put_get_remove():
4343
self.map.unlock(key)
4444
except:
4545
self.logger.exception("Exception in thread")
46-
exceptions.append((threading.currentThread().getName(), sys.exc_info()))
46+
exceptions.append((threading.current_thread().name, sys.exc_info()))
4747

4848
threads = [self.start_new_thread(put_get_remove) for _ in range(0, num_threads)]
4949

tests/unit/proxy/cp/atomic_long_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
import unittest
22

3+
import pytest
34
from mock import MagicMock
45

56
from hazelcast.proxy.cp.atomic_long import AtomicLong
67

78

9+
@pytest.mark.enterprise
810
class AtomicLongInvalidInputTest(unittest.TestCase):
911
def setUp(self):
1012
self.atomic_long = AtomicLong(MagicMock(), None, None, None, None)

tests/unit/proxy/cp/atomic_reference_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
import unittest
22

3+
import pytest
34
from mock import MagicMock
45

56
from hazelcast.proxy.cp.atomic_reference import AtomicReference
67

78

9+
@pytest.mark.enterprise
810
class AtomicReferenceInvalidInputTest(unittest.TestCase):
911
def setUp(self):
1012
self.atomic_ref = AtomicReference(MagicMock(), None, None, None, None)

0 commit comments

Comments
 (0)