Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code completion popup doesn't have margins #5775

Closed
goyalyashpal opened this issue Feb 1, 2023 · 4 comments
Closed

code completion popup doesn't have margins #5775

goyalyashpal opened this issue Feb 1, 2023 · 4 comments
Labels
C-enhancement Category: Improvements

Comments

@goyalyashpal
Copy link
Contributor

... at least in the showcase video on homepage

Hi!
I was watching the helix video at homepage, and noticed that the completion suggestions cling to the left border of popup which makes it hard to differentiate from the sourrounding code.

Is what's shown in video still the case?
I am just starting with helix and devt; so, couldn't verify it myself...

helix code completion popup no margin vivaldi_9VePslIb6S

helix LSP help popup correct margin vivaldi_b1G2LyElVx

@goyalyashpal goyalyashpal added the C-enhancement Category: Improvements label Feb 1, 2023
@gabydd
Copy link
Member

gabydd commented Feb 1, 2023

image

there definitely is padding in the autocomplete, it might not of shown up correctly cause of the recording or an older helix version, I think the current padding is good though as you can see in the screenshot

@pascalkuthe
Copy link
Member

There is already a visual padding in the completion popup as @gabydd showed. It doesn't show up in the recording because the recording is performed with asciinema which has some limitations (screencaps often look a bit odd with it).

As this is not a real problem when actually running helix I am closing this issue

@the-mikedavis
Copy link
Member

the-mikedavis commented Feb 1, 2023

The left-margin for completion menus change was part of 22.08 (#2728) and I think this video was recorded a while before that.

There have been a bunch of other UI improvements like that we now apply syntax highlighting in hover popups (second screenshot). It would be nice to make a new asciinema recording for the site at some point that shows off newer features. I'll open an issue over in helix-editor/website. (Edit: helix-editor/website#30)

@goyalyashpal
Copy link
Contributor Author

The scroll bar always looked a little odd to me because it's rather thin and not aligned to the right.
- @ CptPotato at #2728 (comment)

yeah, the scrollbar on the screenshot shared by @ gabydd is also much much better. glad to see both these fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

4 participants