Skip to content

Commit d28f585

Browse files
docs:pip: fix external dependency output structure
The docs showed external deps stored in subdirectories (e.g. external-dockerfile-parse/), but they are actually stored flat in deps/pip/ alongside PyPI deps. This was changed in 7d06928 . Found the discrepancy while working on uv integration, where I was mirroring hermeto's output directory structure. Updated the directory tree and description to match actual behavior. Signed-off-by: Harshit Bansal <harshitbansal184507@gmail.com>
1 parent cc74879 commit d28f585

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

docs/pip.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -612,19 +612,18 @@ We can look at the `git diff` to see what the package remapping looks like. As
612612
an example,
613613

614614
```diff
615-
- dockerfile-parse @ https://github.com/.../2.0.0.tar.gz \
616-
+ dockerfile-parse @ file:///absolute-path/hermeto-output/deps/pip/.../dockerfile-parse-...tar.gz
615+
-dockerfile-parse @ https://github.com/.../2.0.0.tar.gz \
616+
+dockerfile-parse @ file:///absolute-path/hermeto-output/deps/pip/dockerfile-parse-....tar.gz
617617
```
618618

619-
External dependencies are stored a bit further down the deps/pip tree to avoid
620-
mixing them with PyPI dependencies. The path and filename is an implementation
621-
detail.
619+
External dependencies are stored flat alongside PyPI dependencies in
620+
deps/pip/. The filename includes the checksum hash. The exact filename
621+
format is an implementation detail.
622622

623623
```text
624624
hermeto-output/deps/pip
625625
├── ...
626-
├── external-dockerfile-parse
627-
│ └── dockerfile-parse-external-sha256-36e4469abb0d96b0e3cd656284d5016e8a674cd57b8ebe5af64786fe63b8184d.tar.gz
626+
├── dockerfile-parse-36e4469abb0d96b0e3cd656284d5016e8a674cd57b8ebe5af64786fe63b8184d.tar.gz
628627
└── ...
629628
```
630629

0 commit comments

Comments
 (0)