fix: address comment on TLS

Author: hhieuu

plugins/otel/metrics.go

@@ -36,14 +36,14 @@ func initOTELHTTPExporter(ctx context.Context, config *Config) (metric.Exporter,
 // initOTELGRPCExporter creates an OTLP metrics exporter using gRPC transport.
 func initOTELGRPCExporter(ctx context.Context, config *Config) (metric.Exporter, error) {
 	opts := []otlpmetricgrpc.Option{otlpmetricgrpc.WithEndpoint(config.MetricsEndpoint)}
-	tlsConfig, err := createTLSConfig(config.MetricsTLSCACert, config.MetricsInsecure)
-	if err != nil {
-		return nil, err
-	}
 	var creds credentials.TransportCredentials
-	if tlsConfig.InsecureSkipVerify {
+	if config.MetricsTLSCACert == "" && config.MetricsInsecure {
 		creds = insecure.NewCredentials()
 	} else {
+		tlsConfig, err := createTLSConfig(config.MetricsTLSCACert, config.MetricsInsecure)
+		if err != nil {
+			return nil, err
+		}
 		creds = credentials.NewTLS(tlsConfig)
 	}
 	opts = append(opts, otlpmetricgrpc.WithTLSCredentials(creds))

plugins/otel/traces.go

@@ -27,14 +27,14 @@ type OtelClientGRPC struct {
 
 // NewOtelClientGRPC creates a new OpenTelemetry client for gRPC
 func NewOtelClientGRPC(endpoint string, headers map[string]string, tlsCACert string, insecureMode bool) (*OtelClientGRPC, error) {
-	tlsConfig, err := createTLSConfig(tlsCACert, insecureMode)
-	if err != nil {
-		return nil, err
-	}
 	var creds credentials.TransportCredentials
-	if tlsConfig.InsecureSkipVerify {
+	if tlsCACert == "" && insecureMode {
 		creds = insecure.NewCredentials()
 	} else {
+		tlsConfig, err := createTLSConfig(tlsCACert, insecureMode)
+		if err != nil {
+			return nil, err
+		}
 		creds = credentials.NewTLS(tlsConfig)
 	}
 	conn, err := grpc.NewClient(endpoint, grpc.WithTransportCredentials(creds))