Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

Using browser's back button #35

Open
yigitbacakoglu opened this issue Nov 4, 2016 · 10 comments
Open

Using browser's back button #35

yigitbacakoglu opened this issue Nov 4, 2016 · 10 comments
Labels

Comments

@yigitbacakoglu
Copy link

If you click 'Back Button' on browser or (swipe your magic mouse to left) after you click any link that changes the view (eg. Click on a tag), latest view slides down and the container remains empty.

@hibiken
Copy link
Owner

hibiken commented Nov 5, 2016

@yigitbacakoglu Thanks for the bug report. If anyone can fix this issue, please submit a PR 👍

@hibiken hibiken added the bug label Nov 5, 2016
@rawdreeg
Copy link

will work on this ...

@rawdreeg
Copy link

rawdreeg commented Feb 1, 2017

@kenny-hibino issue is caused by Turbolinks not playing nice with JS. Removing turbolinks should fix this

R

@garrettcadams
Copy link

@rawdreeg fork it and fix it i will give you a vps to work in i love this project but i dont know anything about ruby i want to use it as and open source project team blog

@AjayBarot
Copy link
Contributor

@rawdreeg @kenny-hibino : This issue has been already reported to react-rails. Please see this github issue. and changed has been pushed into master branch of react-rails. So by updating react-rails gem this issue will resolved. And I prefer not to remove turbolinks.

@rawdreeg
Copy link

rawdreeg commented Mar 13, 2017 via email

@hibiken
Copy link
Owner

hibiken commented Mar 14, 2017

@AjayBarot I merged your pull request! I'm still seeing the bug with the back navigation. Do you have bandwidth to investigate further?

@AjayBarot
Copy link
Contributor

AjayBarot commented Mar 15, 2017

@kenny-hibino : I suspect progress bar issue and some part of UI is not showing after back button. Issue is with turbolinks caching. Following are the possible solutions.

  1. Update the turbolinks to newer version. right now we are using turbolinks 2.5.3
  2. On particular page disable turbolinks.
  3. Removed turbolinks gem and js from the project.

I am working on solution 1 and I will submit PR tomorrow.

Please share your suggestion and concern.

@dripisforever
Copy link

@AjayBarot is there any news?

@AjayBarot
Copy link
Contributor

@strivemag : I created one pull request regarding this issue. and pull request still need to reviewed. #45

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants