Skip to content

Commit e9e6bc2

Browse files
authored
Merge pull request #109 from holdenweb/tidyup
Tidyup
2 parents 9462bb1 + 3de876f commit e9e6bc2

File tree

6 files changed

+109
-12
lines changed

6 files changed

+109
-12
lines changed

.github/workflows/lint.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,6 @@ jobs:
2727
python -m pip install --upgrade pip poetry
2828
poetry install
2929
- name: Run Ruff
30-
run: poetry run ruff check --output-format=github && poetry run pycodestyle src
30+
run: poetry run ruff check --output-format=github
3131
- name: Run tests under Python ${{ matrix.python-version }}
3232
run: poetry run make test

Makefile

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@ tox-test:
2222
build:
2323
python build_hu.py
2424

25-
style_check:
25+
style-check:
2626
poetry run flake8 src && echo flake8 done
27-
poetry run pycodestyle src && echo pycodestyle done
2827

2928
watch-test:
3029
@make test --silent || exit 0

poetry.lock

+95-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ setuptools = "^75.6.0"
2323

2424
[tool.poetry.group.dev.dependencies]
2525
ruff = "^0.8.4"
26+
black = "^24.10.0"
2627

2728
[build-system]
2829
requires = ["poetry_core>=1.0.0"]

src/hu/dotted_dict.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,9 @@ def _apply_key(self, o, k):
2727
except ValueError:
2828
raise KeyError("Non-integer list subscript")
2929
except IndexError:
30-
raise KeyError(f'Invalid list index at end of "{k[: self.pos]}"')
30+
raise KeyError(f'Invalid list index in "{k[: self.pos]}"')
3131
except KeyError:
32-
raise KeyError(
33-
'Unrecognised field name at end of "{}"'.format(k[: self.pos])
34-
)
32+
raise KeyError(f'Unrecognised field name in "{k[: self.pos]}"')
3533

3634
def __getitem__(self, key):
3735
"""

tests/test_dotted_dict.py

+9-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import pytest
2-
32
from hu import DottedDict
43

54

@@ -19,7 +18,14 @@ def test_subscripts(dd):
1918

2019

2120
def test_fragments(dd):
22-
assert list(dd._parse_path_key_spec("ab.cd[2][-1].ef.ij")) == ["ab", "cd", 2, -1, "ef", "ij"]
21+
assert list(dd._parse_path_key_spec("ab.cd[2][-1].ef.ij")) == [
22+
"ab",
23+
"cd",
24+
2,
25+
-1,
26+
"ef",
27+
"ij",
28+
]
2329
assert list(dd._parse_path_key_spec("ab.cd[2].banana.ef.ij")) == [
2430
"ab",
2531
"cd",
@@ -46,7 +52,7 @@ def test_deletion(dd):
4652
def test_does_not_recursively_create_missing_structures():
4753
dd = DottedDict({"first": {"second": [{}, {}, {"third": "bingo"}]}})
4854
with pytest.raises(KeyError):
49-
dd['missing.element'] = None
55+
dd["missing.element"] = None
5056

5157

5258
def test_name_patterns(dd):

0 commit comments

Comments
 (0)