Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Holonix versions on main-0.4 #107

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Automated Holochain version bump.

To apply more updates to this PR you can ask the bot to make changes. Try commenting with:

  • @hra bump holochain
  • @hra bump hc-launch
  • @hra bump hc-scaffold

You must be in the list of allowed users for this to work!

auto-merge was automatically disabled December 17, 2024 21:46

Pull request was closed

@ThetaSinner ThetaSinner reopened this Dec 17, 2024
@matthme
Copy link
Contributor

matthme commented Dec 17, 2024

@hra bump hc-launch

@c12i
Copy link
Contributor

c12i commented Dec 18, 2024

@hra bump hc-launch

c12i
c12i previously approved these changes Dec 18, 2024
@c12i c12i closed this Dec 18, 2024
@c12i c12i reopened this Dec 18, 2024
@matthme matthme self-requested a review December 18, 2024 13:24
matthme
matthme previously approved these changes Dec 18, 2024
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right

@matthme
Copy link
Contributor

matthme commented Dec 18, 2024

Which part, that there are no holochain updates? hc-launch and hc-scaffold look right to me.

@matthme
Copy link
Contributor

matthme commented Dec 18, 2024

@hra bump holochain

@ThetaSinner
Copy link
Member

I think the update script doesn't know how to switch from an RC to a release for Holochain. I'll have to do it manually

@ThetaSinner ThetaSinner dismissed stale reviews from matthme and c12i via 3cb2291 December 18, 2024 15:59
@ThetaSinner
Copy link
Member

I'm slightly confused when the scaffolding got updated because @c12i commented asking for hc-launch.

Please could you check that scaffolding is showing the expected version?

@c12i
Copy link
Contributor

c12i commented Dec 18, 2024

I triggered this build while this PR was open, which I wasn't aware of at the time. And it seemed to update this PR instead of creating a new one via this force push

On looking at the diff, the changes @matthme had made seemed to have been overridden by the said force push commit, hence why I asked for hc-launch to be updated again.

The commit hash getting referenced in the diff for scaffolding is the correct one though

@ThetaSinner
Copy link
Member

I see! Okay, that all makes sense now :)

@ThetaSinner ThetaSinner merged commit ae95497 into main-0.4 Dec 18, 2024
18 checks passed
@ThetaSinner ThetaSinner deleted the holochain-update-c8b0c98 branch December 18, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants