Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holder of Item is not implemented the Rails Way #273

Open
jacob271 opened this issue Jan 12, 2023 · 0 comments
Open

Holder of Item is not implemented the Rails Way #273

jacob271 opened this issue Jan 12, 2023 · 0 comments
Assignees
Labels
BP-TF BP Friedrich Bug Something isn't working

Comments

@jacob271
Copy link
Collaborator

Request for Refactoring: Accessing the holder of an item can not be done as intended by Rails

Problem Description

Instead of having a reference to the holder, we currently use a user_id which is just an integer.

This is why we have to use
Item.where(holder: max.id) instead of Item.where(holder: max).

Steps For Reproduction

No steps for reproduction since this is more of a request for refactoring than a bug.

@jacob271 jacob271 added Bug Something isn't working BP-TF BP Friedrich labels Jan 12, 2023
@jacob271 jacob271 self-assigned this Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BP-TF BP Friedrich Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant