Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation problems #160

Closed
10 tasks done
frcroth opened this issue Jan 29, 2021 · 12 comments · Fixed by #177
Closed
10 tasks done

Navigation problems #160

frcroth opened this issue Jan 29, 2021 · 12 comments · Fixed by #177
Labels
bug Something isn't working product-owners Issues to be addressed by the POs

Comments

@frcroth
Copy link
Contributor

frcroth commented Jan 29, 2021

Mobile:

  • What does the 4th button (the fa-history button) do / what is planned here?
  • Proposals and activities should be removed
  • Double navbar is a little weird
  • Chat and home are selected at the same time
  • Chat in the lower navbar does not lead to chat
  • Chat is not scrolled down (Chat does not scroll all the way down on mobile #178)

Desktop:

  • Contacts and requests are not visible
  • Proposals and activities should be removed
  • There is no way to get to my own page
  • There is no way to return to dashboard when on a seperate page
  • There is no way to go to contacts
@frcroth frcroth added the bug Something isn't working label Jan 29, 2021
@LinqLover
Copy link
Contributor

IMO this should get a high priority, it's a massive regression of our product

@rheaSPK
Copy link
Collaborator

rheaSPK commented Jan 29, 2021

This isn't a bug, these exact points were explicitly mentioned in the acceptance criterias. I'm not happy with this solution too, so yes, this should be fixed. Maybe we should keep the old navbar for desktop and add the new one only for mobile... But that's up to the POs

@rheaSPK rheaSPK added invalid This doesn't seem right and removed bug Something isn't working labels Jan 29, 2021
@LinqLover
Copy link
Contributor

I believe the POs would expect us not to give up our common sense, it's just their responsibility to steer and overview the entire product in great detail ... But however, @florian-papsdorf would be nice to provide an appropriate wireframe to solve this :-)

@LinqLover LinqLover added bug Something isn't working product-owners Issues to be addressed by the POs and removed invalid This doesn't seem right labels Jan 29, 2021
@j-hellenberg
Copy link

We currently don't care about the desktop version at all.

Concerning the mobile version, I think the points Felix brought up are what's left to do to reach proper navigation following the wireframes in #138 (+ chat tab).
Refer to #138 as well to see what is planned in the history tab.

@Alexander-Dubrawski
Copy link
Contributor

Alexander-Dubrawski commented Jan 29, 2021

There is still one bug with the navigation bar. If you click on the search icon the link of the settings page is expanding over the whole page. That means that if I click somewhere on the page I get redirected to the edit user page. A quick fix for that is to wrap the link and Icon into a label and then give the label and link the following styling:

    .nav-bar-entry {
      position: relative;
    }

and the link should get the styling:

    a::after {
        content: '';
        position: absolute;
        top: 0;
        left: 0;
        bottom: 0;
        right: 0;
    }

so for example the code could look as:

...
      <li class="nav-item">
        <!-- please update the path when reworked the chat -->
          <label class="nav-bar-entry">
          <a class="nav-link <%= active_link_to_class(root_path, active: :exclusive)%>" href="<%= root_url %>">
            <i class="fa fa-comments"></i>
          </a>
        </label>
      </li>
...

This is just a small trick to style links correctly.

@Alexander-Dubrawski
Copy link
Contributor

@rheaSPK is it still possible to log out, or am I missing something? 🙃

@rheaSPK
Copy link
Collaborator

rheaSPK commented Jan 29, 2021

No, unfortunately it's not. This could be added in the settings page...

@LinqLover
Copy link
Contributor

This could be added in the settings page...

Planned as part of #47.

@frcroth
Copy link
Contributor Author

frcroth commented Feb 1, 2021

Removed activities and proposals with #164

@frcroth
Copy link
Contributor Author

frcroth commented Feb 4, 2021

#177 fixes this

Fixes #160 (apart from non-clickable history, that is described in #166 and scrolling down in the chat that is addressed in #178)

@LinqLover
Copy link
Contributor

LinqLover commented Feb 5, 2021

  • Chat is not scrolled down

is still unchecked

@frcroth
Copy link
Contributor Author

frcroth commented Feb 5, 2021

  • Chat is not scrolled down

is still unchecked

Yes but its #178 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product-owners Issues to be addressed by the POs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants