-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation problems #160
Comments
IMO this should get a high priority, it's a massive regression of our product |
This isn't a bug, these exact points were explicitly mentioned in the acceptance criterias. I'm not happy with this solution too, so yes, this should be fixed. Maybe we should keep the old navbar for desktop and add the new one only for mobile... But that's up to the POs |
I believe the POs would expect us not to give up our common sense, it's just their responsibility to steer and overview the entire product in great detail ... But however, @florian-papsdorf would be nice to provide an appropriate wireframe to solve this :-) |
There is still one bug with the navigation bar. If you click on the search icon the link of the settings page is expanding over the whole page. That means that if I click somewhere on the page I get redirected to the edit user page. A quick fix for that is to wrap the link and Icon into a label and then give the label and link the following styling: .nav-bar-entry {
position: relative;
} and the link should get the styling: a::after {
content: '';
position: absolute;
top: 0;
left: 0;
bottom: 0;
right: 0;
} so for example the code could look as: ...
<li class="nav-item">
<!-- please update the path when reworked the chat -->
<label class="nav-bar-entry">
<a class="nav-link <%= active_link_to_class(root_path, active: :exclusive)%>" href="<%= root_url %>">
<i class="fa fa-comments"></i>
</a>
</label>
</li>
... This is just a small trick to style links correctly. |
@rheaSPK is it still possible to log out, or am I missing something? 🙃 |
No, unfortunately it's not. This could be added in the settings page... |
Planned as part of #47. |
Removed activities and proposals with #164 |
is still unchecked |
Yes but its #178 now |
Mobile:
Desktop:
The text was updated successfully, but these errors were encountered: