Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move start user id param to settings #461

Open
chrisma opened this issue Mar 11, 2019 · 0 comments
Open

Move start user id param to settings #461

chrisma opened this issue Mar 11, 2019 · 0 comments
Labels
enhancement New feature or request prio: low This is a low priority issue.

Comments

@chrisma
Copy link
Contributor

chrisma commented Mar 11, 2019

Currently config.start_user_id = 4000 is set in all three configured environments, i.e. config/environments/production.rb, config/environments/development.rb and config/environments/development.rb.
This is redundant.

Ideally, this setting would be handled in the same way as all other settings, be configurable and have a sane default set in seeds.rb. Alternatively, at least move it to a global config like VmPortal::Application (config/application.rb) to remove the duplication and allow easier maintenance.

See also #399

@chrisma chrisma added the prio: low This is a low priority issue. label Mar 11, 2019
@chrisma chrisma added the enhancement New feature or request label Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio: low This is a low priority issue.
Projects
None yet
Development

No branches or pull requests

1 participant