Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inline JS #507

Open
chrisma opened this issue Mar 24, 2019 · 0 comments
Open

Remove inline JS #507

chrisma opened this issue Mar 24, 2019 · 0 comments
Labels
prio: low This is a low priority issue. refactoring

Comments

@chrisma
Copy link
Contributor

chrisma commented Mar 24, 2019 •
edited
Loading

Some views feature inline JS in <script> tags which is hard to maintain, e.g. app/views/servers/_form.html.erb.

  • Search codebase for all uses of <script> in views
  • Check if JS is needed or if Bootstrap can help
  • If needed: Move to separate JS file and trigger on data- attribute
@chrisma chrisma mentioned this issue Mar 24, 2019
Open
@chrisma chrisma added prio: low This is a low priority issue. refactoring labels Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: low This is a low priority issue. refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisma