Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parsing puppetscript #514

Open
chrisma opened this issue Mar 25, 2019 · 1 comment
Open

Refactor parsing puppetscript #514

chrisma opened this issue Mar 25, 2019 · 1 comment

Comments

@chrisma
Copy link
Contributor

chrisma commented Mar 25, 2019 •
edited
Loading

  • Investigate if there is a Ruby lib for parsing puppetscripts
  • Parse using regexes with context information in capture groups
  • Don't rely on the line number of scripts
  • Get rid of node_file_correct?
  • What happens if only a single pp file is broken? Does the entire system go down?
@chrisma
Copy link
Contributor Author

chrisma commented Apr 3, 2019

We could make this more generic by relying solely on a regex to extract the user names, regardless of which line they are in, similar to \$admins\s*=\s*\[["|'](\S+)["|']\] , see: https://rubular.com/r/4AJ5PUkYflmzcK

@chrisma chrisma mentioned this issue Apr 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisma