You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The CLI options parsing in chafa.c has grown into a big, unwieldy and hard to follow blob. It also has all kinds of ad-hoc logic (defaults, dependent settings, etc) mixed in. We need to refactor this, preferably into its own options.c unit that can produce a struct with just the raw options.
A couple of points:
Every option must have an auto or unset state.
It should be possible to merge option structs from different sources in the future (e.g. from config file, env vars).
Defaults must be applied by separate logic after the options have been parsed and merged. Consider that some of the defaults may come from probing (which itself can be turned off with an option).
The text was updated successfully, but these errors were encountered:
The CLI options parsing in
chafa.c
has grown into a big, unwieldy and hard to follow blob. It also has all kinds of ad-hoc logic (defaults, dependent settings, etc) mixed in. We need to refactor this, preferably into its ownoptions.c
unit that can produce a struct with just the raw options.A couple of points:
auto
orunset
state.The text was updated successfully, but these errors were encountered: