Extra characters deleted with a region

[ThibautVerron]

Hi,

When calling the smart commands from keybindings with a region selected, smart-hungry-delete-forward-char will also delete the char after point, and smart-hungry-delete-backward-char also deletes the char before point. If the char is whitespace, it will hungrily delete it.

For example, with ([] being point and | mark):

ab[]cde|fg

pressing backspace results in

a[]fg

instead of

ab[]fg

The weird thing is that it only happens if the functions are called from a bound key. Using M-x smart-hungry-delete-XXX-char works fine in both cases, deleting only the region.

It also appears to be two actions for undo: one undo will undo the character deletion, the second will undo the region deletion.

I don't know if it is related to #3 (regarding delete-selection-mode).

Cheers!

[blue0513]

I also face this problem.
And when I revert this commit, the problem doesn't occur.

[ThibautVerron]

So it seems that it is indeed related to delete-selection-mode, as per the last comment.

One can also observe, with the debugger, that the region is deleted before any of the smart-hungry-delete functions are called, and those then delete one additional character. Clearly this cannot be the intended behavior.

This also suggests that the fix to #3 is incorrect. (As an aside, I do use delete-selection-mode, and I don't see anything surprising without those symbol properties. So I don't see what was the problem reported in that other issue.)

As a user-level fix until a permanent solution is found, one can add

(put #'smart-hungry-delete-backward-char 'delete-selection nil)
(put #'smart-hungry-delete-forward-char 'delete-selection nil)

to their init file after loading the package.