fix: stop ruleset/config leaking between runs and fix rule checks

- core: copy the ruleset in verify() so inline <!-- htmlhint --> rules
  don't mutate the caller's or the default ruleset
- tags-check: don't persist custom config in module state across runs
- doctype-html5: listen to comment events only, so the listener is
  actually removed after the first tag
- html-lang-require: anchor the BCP47 pattern to the whole value
- tag-pair: treat bgsound as a void element

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FN9Si1bR6igGbuoJ7ZGJWb

Author: claude

src/core/core.ts

@@ -32,6 +32,10 @@ class HTMLHintCore {
       ruleset = this.defaultRuleset
     }
 
+    // Copy the ruleset so inline <!-- htmlhint --> rules don't leak into the
+    // caller's ruleset (or the shared default ruleset) on later calls
+    ruleset = { ...ruleset }
+
     // parse inline ruleset
     html = html.replace(
       /^\s*<!--\s*htmlhint\s+([^\r\n]+?)\s*-->/i,

src/core/rules/doctype-html5.ts

@@ -25,7 +25,7 @@ export default {
       parser.removeListener('tagstart', onTagStart)
     }
 
-    parser.addListener('all', onComment)
+    parser.addListener('comment', onComment)
     parser.addListener('tagstart', onTagStart)
   },
 } as Rule

src/core/rules/html-lang-require.ts

@@ -32,7 +32,7 @@ export default {
       const tagName = event.tagName.toLowerCase()
       const mapAttrs = parser.getMapAttrs(event.attrs)
       const col = event.col + tagName.length + 1
-      const langValidityPattern = new RegExp(languageTag, 'g')
+      const langValidityPattern = new RegExp(`^${languageTag}$`)
 
       if (tagName === 'html') {
         if ('lang' in mapAttrs) {

src/core/rules/tag-pair.ts

@@ -7,7 +7,7 @@ export default {
   init(parser, reporter) {
     const stack: Array<Partial<Block>> = []
     const mapEmptyTags = parser.makeMap(
-      'area,base,basefont,br,col,frame,hr,img,input,isindex,link,meta,param,embed,track,command,source,keygen,wbr'
+      'area,base,basefont,bgsound,br,col,frame,hr,img,input,isindex,link,meta,param,embed,track,command,source,keygen,wbr'
     ) //HTML 4.01 + HTML 5
 
     parser.addListener('tagstart', (event) => {

src/core/rules/tags-check.ts

@@ -1,6 +1,6 @@
 import { Rule } from '../types'
 
-let tagsTypings: Record<string, Record<string, unknown>> = {
+const defaultTagsTypings: Record<string, Record<string, unknown>> = {
   a: {
     selfclosing: false,
     attrsRequired: ['href', 'title'],
@@ -33,7 +33,7 @@ export default {
   id: 'tags-check',
   description: 'Checks html tags.',
   init(parser, reporter, options: Record<string, Record<string, unknown>>) {
-    tagsTypings = { ...tagsTypings, ...options }
+    const tagsTypings = { ...defaultTagsTypings, ...options }
 
     parser.addListener('tagstart', (event) => {
       const attrs = event.attrs

test/core.spec.js

@@ -206,4 +206,17 @@ describe('Core', () => {
       expect(messages[0].rule.id).toBe('attr-lowercase')
     })
   })
+
+  it('Inline ruleset should not leak into later verify calls', () => {
+    const ruleset = { 'tag-pair': true }
+    HTMLHint.verify(
+      '<!-- htmlhint alt-require:true --><img src="a.png">',
+      ruleset
+    )
+    expect(ruleset).toEqual({ 'tag-pair': true })
+
+    HTMLHint.verify('<!-- htmlhint alt-require:true --><img src="a.png">')
+    const messages = HTMLHint.verify('<img src="a.png">')
+    expect(messages.filter((m) => m.rule.id === 'alt-require').length).toBe(0)
+  })
 })

test/rules/doctype-html5.spec.js

@@ -22,4 +22,10 @@ describe(`Rules: ${ruleId}`, () => {
     const messages = HTMLHint.verify(code, ruleOptions)
     expect(messages.length).toBe(0)
   })
+
+  it('Non-doctype declarations after the first tag should not result in an error', () => {
+    const code = '<!DOCTYPE html><html><![CDATA[ x ]]></html>'
+    const messages = HTMLHint.verify(code, ruleOptions)
+    expect(messages.length).toBe(0)
+  })
 })

test/rules/html-lang-require.spec.js

@@ -36,4 +36,9 @@ describe(`Rules: ${ruleId}`, () => {
     const messages = HTMLHint.verify(code, ruleOptions)
     expect(messages.length).toBe(0)
   })
+  it('HTML tag with a lang value containing invalid characters should result in an error', () => {
+    const code = '<html lang="en_US"></html>'
+    const messages = HTMLHint.verify(code, ruleOptions)
+    expect(messages.length).toBe(1)
+  })
 })

test/rules/tag-pair.spec.js

@@ -49,4 +49,10 @@ describe(`Rules: ${ruleId}`, () => {
     const messages = HTMLHint.verify(code, ruleOptions)
     expect(messages.length).toBe(0)
   })
+
+  it('Void bgsound tag should not result in an error', () => {
+    const code = '<body><bgsound src="a.mid"></body>'
+    const messages = HTMLHint.verify(code, ruleOptions)
+    expect(messages.length).toBe(0)
+  })
 })

test/rules/tags-check.spec.js

@@ -57,4 +57,9 @@ describe(`Rules: ${ruleId}`, () => {
     messages = HTMLHint.verify(code, ruleOptions)
     expect(messages.length).toBe(1)
   })
+  it('Should not leak custom config into later runs', () => {
+    const code = '<sometag></sometag>'
+    const messages = HTMLHint.verify(code, { [ruleId]: {} })
+    expect(messages.length).toBe(0)
+  })
 })