Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node versions used on GitHub Actions #1202

Closed
coliff opened this issue Oct 17, 2022 · 3 comments · Fixed by #1283
Closed

Update Node versions used on GitHub Actions #1202

coliff opened this issue Oct 17, 2022 · 3 comments · Fixed by #1283
Assignees
@coliff
Labels
keep-unstale The issue will not be marked as stale by the stale-bot

Comments

@coliff
Copy link
Member

coliff commented Oct 17, 2022

I suggest we drop Node v17 and maybe v14 and add v18.

For reference here are the currently supported Node versions:
https://github.com/nodejs/release#nodejs-release-working-group
@nschonni
Copy link
Contributor

👍 to dropping 17, 👎 on 14 since it doesn't hit EOL till April 2023
Also good adding 18 (and 19 as of today)

@nschonni
Copy link
Contributor

Would probably make sense to add engines to package.json to be explicit about the supported/tested versions

@stale
Copy link

stale bot commented Dec 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the bot:stale Issue marked as stale because there was no activity label Dec 26, 2022
@coliff coliff added keep-unstale The issue will not be marked as stale by the stale-bot and removed bot:stale Issue marked as stale because there was no activity labels Dec 26, 2022
@coliff coliff self-assigned this Feb 9, 2023
@coliff coliff linked a pull request Feb 10, 2023 that will close this issue
Update Node versions used on GitHub Actions #1283
Merged
@nschonni nschonni mentioned this issue Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coliff coliff

Labels
keep-unstale The issue will not be marked as stale by the stale-bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Node versions used on GitHub Actions htmlhint/HTMLHint
2 participants
@coliff @nschonni