Skip to content

Commit adc3891

Browse files
younesbelkadayounesbelkada
committed
test new slack message
1 parent fdfbcb2 commit adc3891

File tree

3 files changed

+61
-48
lines changed

3 files changed

+61
-48
lines changed

‎.github/workflows/push-important-models.yml

+14-47
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Slow tests on important models (on Push - A10)
22

33
on:
44
push:
5-
branches: [ main ]
5+
branches: [ add-new-push-test-workflow ]
66

77
env:
88
RUN_SLOW: "yes"
@@ -66,59 +66,26 @@ jobs:
6666
- name: Run FA2 tests
6767
id: run_fa2_tests
6868
run:
69-
pytest -m "flash_attn_test" tests/${{ matrix.model-name }}/test_modeling_*
70-
- name: Post results Slack channel
69+
pytest -m "flash_attn_test" --make-reports=${{ matrix.model-name }}_fa2_tests/ tests/${{ matrix.model-name }}/test_modeling_*
70+
- name: Post to Slack
7171
if: always()
72-
id: post-slack-fa2
73-
uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001
72+
uses: ./.github/workflows/send-slack.yml
7473
with:
75-
# Slack channel id, channel name, or user id to post message.
76-
# See also: https://api.slack.com/methods/chat.postMessage#channels
77-
channel-id: ${{ env.OUTPUT_SLACK_CHANNEL_ID }}
78-
# For posting a rich message using Block Kit
79-
payload: |
80-
{
81-
"text": "Slow FA 2 tests on ${{ matrix.model-name }} result: ${{ steps.run_fa2_tests.conclusion }}\n\n${{ github.event.pull_request.html_url || github.event.head_commit.url }}",
82-
"blocks": [
83-
{
84-
"type": "section",
85-
"text": {
86-
"type": "mrkdwn",
87-
"text": "FA2 tests for ${{ matrix.model-name }}: ${{ steps.run_fa2_tests.conclusion }}\n\n Commit: ${{ github.event.pull_request.html_url || github.event.head_commit.url }} \n\n Action URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
88-
}
89-
}
90-
]
91-
}
92-
env:
93-
SLACK_BOT_TOKEN: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }}
74+
slack_channel: ${{ env.OUTPUT_SLACK_CHANNEL_ID }}
75+
title: FA2 tests - ${{ matrix.model-name }}
76+
status: ${{ steps.run_fa2_tests.conclusion}}
77+
secrets: inherit
9478

9579
- name: Run integration tests
9680
id: run_integration_tests
9781
if: always()
9882
run:
9983
pytest -k "IntegrationTest" tests/${{ matrix.model-name }}/test_modeling_*
100-
- name: Post results Slack channel
84+
- name: Post to Slack
10185
if: always()
102-
id: post-slack-integration-tests
103-
#uses: slackapi/[email protected]
104-
uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001
86+
uses: ./.github/workflows/send-slack.yml
10587
with:
106-
# Slack channel id, channel name, or user id to post message.
107-
# See also: https://api.slack.com/methods/chat.postMessage#channels
108-
channel-id: ${{ env.OUTPUT_SLACK_CHANNEL_ID }}
109-
# For posting a rich message using Block Kit
110-
payload: |
111-
{
112-
"text": "Slow integration tests on ${{ matrix.model-name }} result: ${{ steps.run_integration_tests.conclusion }}\n\n${{ github.event.pull_request.html_url || github.event.head_commit.url }}",
113-
"blocks": [
114-
{
115-
"type": "section",
116-
"text": {
117-
"type": "mrkdwn",
118-
"text": "Integration tests on ${{ matrix.model-name }}: ${{ steps.run_integration_tests.conclusion}}\n\n Commit: ${{ github.event.pull_request.html_url || github.event.head_commit.url }} \n\n Action URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
119-
}
120-
}
121-
]
122-
}
123-
env:
124-
SLACK_BOT_TOKEN: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }}
88+
slack_channel: ${{ env.OUTPUT_SLACK_CHANNEL_ID }}
89+
title: Integration tests - ${{ matrix.model-name }}
90+
status: ${{ steps.run_integration_tests.conclusion}}
91+
secrets: inherit

‎.github/workflows/send-slack.yml

+47
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
name: Send message to slack
2+
3+
on:
4+
workflow_call:
5+
inputs:
6+
slack_channel:
7+
required: true
8+
type: string
9+
title:
10+
required: true
11+
type: string
12+
status:
13+
require: true
14+
type: string
15+
16+
jobs:
17+
send_slack:
18+
- name: Post results Slack channel
19+
id: post-slack
20+
uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001
21+
with:
22+
# Slack channel id, channel name, or user id to post message.
23+
# See also: https://api.slack.com/methods/chat.postMessage#channels
24+
channel-id: ${{ inputs.slack_channel }}
25+
# For posting a rich message using Block Kit
26+
payload: |
27+
{
28+
"text": "Slow integration tests on ${{ inputs.title }}",
29+
"blocks": [
30+
{
31+
"type": "header",
32+
"text": {
33+
"type": "plain_text",
34+
"text": "🤗 Results of the ${{ inputs.title }} tests.",
35+
},
36+
},
37+
{
38+
"type": "section",
39+
"text": {
40+
"type": "mrkdwn",
41+
"text": "Result: ${{ inputs.status == 'success' ? 🟢 : 🔴 }} ${{ inputs.status }} \n\n Commit: ${{ github.event.pull_request.html_url || github.event.head_commit.url }} \n\n Action URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
42+
}
43+
}
44+
]
45+
}
46+
env:
47+
SLACK_BOT_TOKEN: ${{ secrets.SLACK_CIFEEDBACK_BOT_TOKEN }}

‎src/transformers/models/llama/modeling_llama.py

-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959

6060
_CONFIG_FOR_DOC = "LlamaConfig"
6161

62-
6362
def _get_unpad_data(attention_mask):
6463
seqlens_in_batch = attention_mask.sum(dim=-1, dtype=torch.int32)
6564
indices = torch.nonzero(attention_mask.flatten(), as_tuple=False).flatten()

0 commit comments

Comments
 (0)