fix: dtype might change during resize #36089
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed a small bug, where an np.ndarray changes dtype when calling resize:
When using natural numbers in a float array, the image is not rescaled and converted into a
PIL.Image
as-is but when returning back to a numpy array, the type staysuint8
.This PR, stores the original dtype and casts the array back to this type before returning. I also added tests to check for this behavior in the future.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
I think @amyeroberts might be best suited since she wrote lots of surrounding code.