Repository navigation
Conversation
Contributor
|
Thank you for your contribution 🤗! CI Security Gate — waiting for maintainer approvalCI is approved automatically only for authors who already have a contribution merged in this repository. A maintainer will review this PR and approve CI to run on it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use each observed evaluation batch size when expanding its mean loss before gathering.
With an unknown-length iterable dataset and
accelerator_config={"dispatch_batches": False}, the final batch can be shorter than the configured batch size. Its mean loss is currently repeated for a full batch. Accelerate cannot trim this unknown-length loader by a known dataset remainder, so the tail is overweighted in bothevaluate()andpredict().The existing configured-size fallback remains for inputs whose batch size cannot be inferred. Gathering, accumulation, and the reduction of model losses are unchanged.
Reproduction and validation
Native CPU validation: https://github.com/Afloat16/transformers/actions/runs/43406792756
evaluate()/predict(), an independent MSE reference, dispatch enabled/disabled, accumulation enabled/disabled, and batch sizes 1, 3, and 8 for seven examples.GPT2Config(),GPT2LMHeadModel,Trainer, and the same Hugging FaceDatasetconverted withto_iterable_dataset(). With batch size 3 and seven examples:The GPT-2 check uses locally initialized weights and verifies evaluation aggregation; it is not a model-quality benchmark. Validation ran on CPU, without distributed or GPU claims.
Commands:
Full
make stylepasses, with 5,108 files unchanged.Related work
This is a standalone reproduction. The existing batch-size fix in #16763 selected the configured total batch size for data parallelism. The Accelerate migration in #24028 removed the old final truncation of losses and delegated gathering to Accelerate; this patch instead makes each local loss expansion match the batch that produced it. Related evaluation-loop changes and current open/closed PRs were checked for the same fix.