Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confusing #1

Open
keithyin opened this issue Sep 1, 2017 · 1 comment
Open

confusing #1

keithyin opened this issue Sep 1, 2017 · 1 comment

Comments

@keithyin
Copy link

keithyin commented Sep 1, 2017

Hi, i read your code, and it is easy to understand, but there is one line of code that i'm confusing about. https://github.com/transedward/pytorch-ddpg/blob/master/agents/ddpg_low_dim.py#L142 , should we use state_batch or next_state_batch to compute the next_action? in the paper, the author use next_state_batch to compute the next_action, am i understand it right?
@hungtuchen
Copy link
Owner

Hey, sorry I thought my last reply was successful.
I think you might be right but I don't have time to test it recently.
Do you mind changing the code and seeing if it performs better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hungtuchen @keithyin