From da401942d672831a1e69fe028aa96d48ab5e7025 Mon Sep 17 00:00:00 2001 From: stp-ekioh Date: Mon, 8 Jul 2024 12:31:37 +0100 Subject: [PATCH] Fix broken 'for' loops in FindElements methods. Previously the code was updating a copy of each element rather than the element in the array. --- element.go | 6 +++--- session.go | 6 +++--- shadowroot.go | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/element.go b/element.go index 707e9f7..60f4688 100644 --- a/element.go +++ b/element.go @@ -74,9 +74,9 @@ func (e *Element) FindElements(strategy LocatorStrategy, selector string) ([]Ele return nil, err } - for _, element := range elements { - element.SessionID = e.SessionID - element.client = e.client + for index, _ := range elements { + elements[index].SessionID = e.SessionID + elements[index].client = e.client } return elements, nil diff --git a/session.go b/session.go index 6d5fcf3..cfb23b2 100644 --- a/session.go +++ b/session.go @@ -300,9 +300,9 @@ func (s *Session) FindElements(strategy LocatorStrategy, selector string) ([]Ele return nil, err } - for _, element := range elements { - element.SessionID = s.ID - element.client = s.client + for index, _ := range elements { + elements[index].SessionID = s.ID + elements[index].client = s.client } return elements, nil diff --git a/shadowroot.go b/shadowroot.go index a29d96c..750925f 100644 --- a/shadowroot.go +++ b/shadowroot.go @@ -45,9 +45,9 @@ func (s *ShadowRoot) FindElements(strategy LocatorStrategy, selector string) ([] return nil, err } - for _, element := range elements { - element.SessionID = s.ID - element.client = s.client + for index, _ := range elements { + elements[index].SessionID = s.ID + elements[index].client = s.client } return elements, nil