Use rapidcheck to enable property-based testing

Author: lucteo

.vscode/settings.json

@@ -5,5 +5,8 @@
         "--clang-tidy",
         "--completion-style=detailed",
         "--header-insertion=iwyu"
-    ]
+    ],
+    "files.associations": {
+        "algorithm": "cpp"
+    }
 }

CMakeLists.txt

@@ -23,6 +23,21 @@ CPMAddPackage(
     VERSION 2.4.12
 )
 
+# Add RapidCheck for property-based testing
+CPMAddPackage(
+    NAME rapidcheck
+    GITHUB_REPOSITORY emil-e/rapidcheck
+    GIT_TAG master
+    OPTIONS "RC_ENABLE_TESTS OFF" "RC_ENABLE_EXAMPLES OFF"
+)
+
+# Suppress deprecation warnings originating from RapidCheck headers only
+if (TARGET rapidcheck)
+    target_compile_options(rapidcheck INTERFACE
+        $<$<CXX_COMPILER_ID:Clang,AppleClang,GNU>:-Wno-deprecated-declarations>
+    )
+endif()
+
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 
 add_library(positionless INTERFACE)
@@ -32,8 +47,12 @@ target_compile_options(positionless INTERFACE
     $<$<CXX_COMPILER_ID:MSVC>:/W4>
 )
 
-add_executable(unit_tests test/tests_main.cpp test/partitioning_tests.cpp test/algorithms_tests.cpp)
-target_link_libraries(unit_tests PRIVATE positionless doctest::doctest)
+add_executable(unit_tests
+    test/tests_main.cpp
+    test/partitioning_tests.cpp
+    test/algorithms_tests.cpp
+)
+target_link_libraries(unit_tests PRIVATE positionless doctest::doctest rapidcheck)
 
 enable_testing()
 add_test(NAME unit_tests COMMAND unit_tests)

include/positionless/partitioning.hpp

@@ -170,7 +170,7 @@ inline void partitioning<Iterator>::add_parts_begin(size_t part_index, size_t co
 template <std::forward_iterator Iterator>
 inline void partitioning<Iterator>::remove_part(size_t part_index) {
   assert(part_index < parts_count());
-  boundaries_.erase(boundaries_.begin() + part_index + 1);
+  boundaries_.erase(boundaries_.begin() + part_index);
 }
 
 } // namespace positionless