refactor: expose virtual id field on the ITeam interface (#1117)

Needed in the upstream fork and putting it here will make the merges easier long term.

Author: dhable

packages/api/src/models/team.ts

@@ -11,6 +11,7 @@ export type TeamCHSettings = {
 
 export type ITeam = {
   _id: ObjectId;
+  id: string;
   name: string;
   allowedAuthMethods?: 'password'[];
   apiKey: string;
@@ -49,6 +50,8 @@ export default mongoose.model<ITeam>(
     },
     {
       timestamps: true,
+      toJSON: { virtuals: true },
+      toObject: { virtuals: true },
     },
   ),
 );

packages/api/src/routers/api/__tests__/team.test.ts

@@ -26,7 +26,7 @@ describe('team router', () => {
 
     expect(new Date(resp.body.createdAt).toString()).not.toBe('Invalid Date');
 
-    expect(_.omit(resp.body, ['_id', 'apiKey', 'createdAt']))
+    expect(_.omit(resp.body, ['_id', 'id', 'apiKey', 'createdAt']))
       .toMatchInlineSnapshot(`
 Object {
   "allowedAuthMethods": Array [],
@@ -55,7 +55,7 @@ Object {
       .expect(200);
 
     await agent.post('/sources').send({
-      team: team._id,
+      team: team.id,
       kind: 'log',
       name: 'My New Source',
       connection: 'local',
@@ -87,11 +87,11 @@ Object {
     const { agent, team } = await getLoggedInAgent(server);
     const user1 = await User.create({
       email: '[email protected]',
-      team: team._id,
+      team: team.id,
     });
     const user2 = await User.create({
       email: '[email protected]',
-      team: team._id,
+      team: team.id,
     });
     const resp = await agent.get('/team/members').expect(200);
 
@@ -182,7 +182,7 @@ Array [
 
     const user1 = await User.create({
       email: '[email protected]',
-      team: team._id,
+      team: team.id,
     });
 
     await agent.delete(`/team/member/${user1._id}`).expect(200);
@@ -198,7 +198,7 @@ Array [
     const invite = await TeamInvite.create({
       email: '[email protected]',
       name: 'Fake Invite',
-      teamId: team._id,
+      teamId: team.id,
       token: 'fake_token',
     });