Skip to content

Commit dd67434

Browse files
authored
disable ASO to properly use publicRuntimeConfig (#514)
Tested via: 1. Build ```sh NODE_ENV=production NEXT_PUBLIC_IS_LOCAL_MODE=true npm run build ``` 2. Run and observe configs are set correctly ```sh HDX_LOCAL_DEFAULT_CONNECTIONS='[{"id":"local","name":"Demo","host":"https://demo-ch.hyperdx.io","username":"demo","password":"demo"}]' HDX_LOCAL_DEFAULT_SOURCES='[{"id":"l701179602","kind":"trace","name":"Demo Traces","connection":"local","from":{"databaseName":"default","tableName":"otel_traces"},"timestampValueExpression":"Timestamp","defaultTableSelectExpression":"Timestamp, ServiceName, StatusCode, round(Duration / 1e6), SpanName","serviceNameExpression":"ServiceName","eventAttributesExpression":"SpanAttributes","resourceAttributesExpression":"ResourceAttributes","traceIdExpression":"TraceId","spanIdExpression":"SpanId","implicitColumnExpression":"SpanName","durationExpression":"Duration","durationPrecision":9,"parentSpanIdExpression":"ParentSpanId","spanKindExpression":"SpanKind","spanNameExpression":"SpanName","logSourceId":"l-758211293","statusCodeExpression":"StatusCode","statusMessageExpression":"StatusMessage"},{"id":"l-758211293","kind":"log","name":"Demo Logs","connection":"local","from":{"databaseName":"default","tableName":"otel_logs"},"timestampValueExpression":"TimestampTime","defaultTableSelectExpression":"Timestamp, ServiceName, SeverityText, Body","serviceNameExpression":"ServiceName","severityTextExpression":"SeverityText","eventAttributesExpression":"LogAttributes","resourceAttributesExpression":"ResourceAttributes","traceIdExpression":"TraceId","spanIdExpression":"SpanId","implicitColumnExpression":"Body","traceSourceId":"l701179602"}]' y start ```
1 parent 71345c2 commit dd67434

13 files changed

+31
-0
lines changed

packages/app/pages/benchmark.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
import BenchmarkPage from '@/BenchmarkPage';
22

33
export default BenchmarkPage;
4+
5+
export { getServerSideProps } from '@/emptyGetServerSideProps';

packages/app/pages/chart.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
import ChartPage from '@/DBChartPage';
22

33
export default ChartPage;
4+
5+
export { getServerSideProps } from '@/emptyGetServerSideProps';
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
import DashboardPage from '@/DBDashboardPage';
22

3+
export { getServerSideProps } from '@/emptyGetServerSideProps';
4+
35
export default DashboardPage;
+2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
import DBDashboardPage from '@/DBDashboardPage';
22
export default DBDashboardPage;
3+
4+
export { getServerSideProps } from '@/emptyGetServerSideProps';

packages/app/pages/index.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
import LandingPage from '@/LandingPage';
22
export default LandingPage;
3+
4+
export { getServerSideProps } from '@/emptyGetServerSideProps';

packages/app/pages/join-team.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
import JoinTeamPage from '@/JoinTeamPage';
22

33
export default JoinTeamPage;
4+
5+
export { getServerSideProps } from '@/emptyGetServerSideProps';

packages/app/pages/login/index.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import AuthPage from '@/AuthPage';
22

3+
export { getServerSideProps } from '@/emptyGetServerSideProps';
4+
35
export default function Login() {
46
return (
57
<div>

packages/app/pages/register.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,5 @@ export default function Register() {
66
</div>
77
);
88
}
9+
10+
export { getServerSideProps } from '@/emptyGetServerSideProps';
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
import SearchPage from '@/DBSearchPage';
22

33
export default SearchPage;
4+
5+
export { getServerSideProps } from '@/emptyGetServerSideProps';

packages/app/pages/search/index.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
import SearchPage from '@/DBSearchPage';
22

33
export default SearchPage;
4+
5+
export { getServerSideProps } from '@/emptyGetServerSideProps';

packages/app/pages/services.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
import ServicesDashboardPage from '@/ServicesDashboardPage';
22
export default ServicesDashboardPage;
3+
4+
export { getServerSideProps } from '@/emptyGetServerSideProps';

packages/app/pages/team/index.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
import TeamPage from '@/TeamPage';
22
export default TeamPage;
3+
4+
export { getServerSideProps } from '@/emptyGetServerSideProps';
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
// Force ASO to be disabled so that we can use dynamic values for
2+
// publicRuntimeConfig for self-hosted configs
3+
export const getServerSideProps = async () => {
4+
return {
5+
props: {},
6+
};
7+
};

0 commit comments

Comments
 (0)