Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presentation Verification - SDJWT Required Claims #366

Open
curtis-h opened this issue Jan 29, 2025 · 1 comment · May be fixed by #388
Open

Presentation Verification - SDJWT Required Claims #366

curtis-h opened this issue Jan 29, 2025 · 1 comment · May be fixed by #388
Assignees
@elribonazo
Labels
enhancement New feature or request type:roadmap

Comments

@curtis-h
Copy link
Contributor

curtis-h commented Jan 29, 2025 •
edited
Loading

Proposed feature

Use "required claims" for determining Credential validity during Presentation Verification.
SDJWT has the concept of "required claims", where the Verifier can specify some claims must be disclosed for verification to continue.
This has been part way coded but needs completion.
@curtis-h curtis-h added the enhancement New feature or request label Jan 29, 2025
@elribonazo
Copy link
Contributor

After a little of research came up with the following:

RequiredClaims is an attribute from our library vendor https://github.com/openwallet-foundation/sd-jwt-js/blob/2c9a65d8df1974cba7b58539e0527de5d8d6ecf5/packages/core/src/index.ts#L216 and is used by the library to determine if the SDJWT has the required fields defined.

In our code, we are using a different approach, not using the libraries requiredClaims parameter, instead we rely on disclosing any available field and then processing its validation with input_descriptor and presentation exchange protocol

We always achieve the same results.

@elribonazo elribonazo linked a pull request Feb 24, 2025 that will close this issue
fix: integratin presentation exchange SDJWT verification with disclosures #388
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elribonazo elribonazo

Labels
enhancement New feature or request type:roadmap
Projects
Hyperledger Identus - Roadmap
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: integratin presentation exchange SDJWT verification with disclosures hyperledger-identus/sdk-ts
3 participants
@elribonazo @curtis-h @yshyn-iohk