Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Design for how to add discv5 support 3 #4087

Open
4 tasks
macfarla opened this issue Jul 12, 2022 · 2 comments
Open
4 tasks

[SPIKE] Design for how to add discv5 support 3 #4087

macfarla opened this issue Jul 12, 2022 · 2 comments

Comments

@macfarla
Copy link
Contributor

macfarla commented Jul 12, 2022

Note

Per Meredith, '... was chatting with Adrian Sutton and he mentioned that the teku discv5 implementation actually holds onto all live nodes in memory instead of just relying on the buckets data structure used within the discovery protocol. When peers are streamed from the discovery service, the bucket structure is searched as well as the list of active sessions.'

Timebox - 3 days

@macfarla macfarla added mainnet peering TeamRevenant GH issues worked on by Revenant Team labels Jul 12, 2022
@macfarla
Copy link
Contributor Author

there is a spec
discv5.1
using the consensys/discovery library which would be v5.1 Consensys/discovery#72

@non-fungible-nelson
Copy link
Contributor

non-fungible-nelson commented Jul 19, 2022

Spoke with the other client teams. It looks like in Geth it is optional for users at this time (the client can run v4 and v5 simultaneously). We are going to have a discussion with them post-Merge to determine when/how we should move all Els to v5. And I would definitely recommend consolidating around the Teku library if it makes sense.

Discord context here on Eth R&D.

@jflo jflo removed the TeamRevenant GH issues worked on by Revenant Team label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants