Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout Rocksdb Snapshots #5394

Open
garyschulte opened this issue Apr 26, 2023 · 0 comments
Open

Timeout Rocksdb Snapshots #5394

garyschulte opened this issue Apr 26, 2023 · 0 comments
Labels
bonsai mainnet snack Smaller coding task - less than a day for an experienced dev

Comments

@garyschulte
Copy link
Contributor

garyschulte commented Apr 26, 2023

Description

In rare instances, bonsai might fail to release a rocksdb snapshot. This prevents compaction of old SST files. This will result in larger size on disk until besu is restarted and the snapshot is released. In addition read performance suffers when old SST files cannot be compacted.

Bonsai worldstate / rocksdb snapshots should implement a timeout to force the worldstate to close and the snapshots to be released to prevent this condition. Careful consideration of the timeout will be necessary to not impact nominal operations of besu and the bonsai worldstate archive. The number of worldstates kept in memory should especially be considered.

Acceptance Criteria

  • timeouts for snapshots
  • no impact to nominal operation of besu
@garyschulte garyschulte added the TeamChupa GH issues worked on by Chupacabara Team label Apr 26, 2023
@non-fungible-nelson non-fungible-nelson added bonsai mainnet snack Smaller coding task - less than a day for an experienced dev labels Aug 1, 2023
@non-fungible-nelson non-fungible-nelson removed the TeamChupa GH issues worked on by Chupacabara Team label Sep 19, 2023
@macfarla macfarla added this to the 2024 Q1 Besu team milestone Feb 2, 2024
@jflo jflo removed this from the 2024 Q1 Besu team milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bonsai mainnet snack Smaller coding task - less than a day for an experienced dev
Projects
None yet
Development

No branches or pull requests

4 participants