Remove the duplicated AcceptanceTestBase

[macfarla]

AcceptanceTestBase and AcceptanceTestBaseJunit5

Once the Privacy ATs are removed in #7347 , all ATs should be able to be moved to Junit5 and we no longer need a Junit4 superclass.

[macfarla]

note this one is blocked by #7347

[aslikaya]

could you assign this to me?

[aslikaya]

This is what I understand: AcceptanceTestBase usage will be replaced with AcceptanceTestBaseJunit5 and then AcceptanceTestBase will be deleted. Is that right? @macfarla

[macfarla]

yep so they both do the same job. think all junit 4 ATs should be gone now (or can be updated) so all ATs can extend a single base class that supports junit 5

[macfarla]

probably the base class we end up keeping should be called AccepanceTestBase without reference to Junit version

[pr9t]

@macfarla As per the above comments, I need to remove the Junit5, right?

[macfarla]

@pr9t since no activity for 2 weeks on this PR #7735 would you like to pick up this issue. We just need to unify the AcceptanceTestBase classes, we don't need 2 any more since everything is now using Junit5. The class that stays should be called AcceptanceTestBase

[aslikaya]

We got together with our group for WIEP, saw the PR and so we thought it was being solved and didn't continue working on this issue:/ unassigning myself now so @pr9t can pick it up

[macfarla]

We got together with our group for WIEP, saw the PR and so we thought it was being solved and didn't continue working on this issue:/ unassigning myself now so @pr9t can pick it up

ok. @pr9t this issue is now blocking merging my PR #7790 - can you let me know if you can work on it this week, otherwise I can do it

[pr9t]

Yes, I will work on it.