Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible renaming of NoData & WithData contracts #63

Open
shorsher opened this issue Jun 27, 2022 · 0 comments
Open

Possible renaming of NoData & WithData contracts #63

shorsher opened this issue Jun 27, 2022 · 0 comments

Comments

@shorsher
Copy link
Member

shorsher commented Jun 27, 2022 •
edited
Loading

Based on conversations in #60, it's been suggested to move away from the NoData and WithData nomenclature currently used for the contracts.

The current thinking is NoData should be removed, so the contracts names are just ERC20 and ERC721, because they are minimum viable implementations of their respective contracts.

WithData could be changed to ERC20FireFly and ERC721FireFly, since these contain all of the extra "recommended" FireFly functionality like URI's and attached data. However, dropping WithData makes the difference between the contracts less obvious. Plus, the FireFly suffix makes it sounds as though they are supposed to be the contract of choice for using with FireFly
@shorsher shorsher self-assigned this Jun 27, 2022
@shorsher shorsher changed the title Rename NoData & WithData contracts Possible renaming of NoData & WithData contracts Jun 27, 2022
@shorsher shorsher removed their assignment Jun 27, 2022
@shorsher shorsher mentioned this issue Jun 27, 2022
Merged
@awrichar awrichar mentioned this issue Sep 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shorsher