fix: cleanup some abstractions for circuit breakers (#71)

Author: aaron-steinfeld

grpc-circuitbreaker-utils/build.gradle.kts

@@ -15,6 +15,7 @@ dependencies {
   implementation("io.github.resilience4j:resilience4j-circuitbreaker:1.7.1")
   implementation("com.typesafe:config:1.4.2")
   implementation("com.google.guava:guava:32.0.1-jre")
+  implementation("jakarta.inject:jakarta.inject-api:2.0.1")
 
   annotationProcessor("org.projectlombok:lombok:1.18.24")
   compileOnly("org.projectlombok:lombok:1.18.24")

grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/CircuitBreakerInterceptorFactory.java

@@ -0,0 +1,15 @@
+package org.hypertrace.circuitbreaker.grpcutils;
+
+import jakarta.inject.Inject;
+import java.time.Clock;
+import lombok.AllArgsConstructor;
+import org.hypertrace.circuitbreaker.grpcutils.resilience.ResilienceCircuitBreakerFactory;
+
+@AllArgsConstructor(onConstructor_ = @Inject)
+public class CircuitBreakerInterceptorFactory {
+  private final Clock clock;
+
+  CircuitBreakerInterceptor buildInterceptor(CircuitBreakerConfiguration<?> configuration) {
+    return ResilienceCircuitBreakerFactory.getCircuitBreakerInterceptor(configuration, clock);
+  }
+}

grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerConfigConverter.java

@@ -18,7 +18,7 @@ public static Map<String, CircuitBreakerConfig> getCircuitBreakerConfigs(
   public static List<String> getDisabledKeys(
       Map<String, CircuitBreakerThresholds> configurationMap) {
     return configurationMap.entrySet().stream()
-        .filter(entry -> entry.getValue().isEnabled())
+        .filter(entry -> !entry.getValue().isEnabled())
         .map(Map.Entry::getKey)
         .collect(Collectors.toList());
   }

grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerFactory.java

@@ -5,9 +5,10 @@
 import java.time.Clock;
 import java.util.Map;
 import org.hypertrace.circuitbreaker.grpcutils.CircuitBreakerConfiguration;
+import org.hypertrace.circuitbreaker.grpcutils.CircuitBreakerInterceptor;
 
 public class ResilienceCircuitBreakerFactory {
-  public static ResilienceCircuitBreakerInterceptor getResilienceCircuitBreakerInterceptor(
+  public static CircuitBreakerInterceptor getCircuitBreakerInterceptor(
       CircuitBreakerConfiguration<?> circuitBreakerConfiguration, Clock clock) {
     Map<String, CircuitBreakerConfig> resilienceCircuitBreakerConfigMap =
         ResilienceCircuitBreakerConfigConverter.getCircuitBreakerConfigs(

grpc-circuitbreaker-utils/src/main/java/org/hypertrace/circuitbreaker/grpcutils/resilience/ResilienceCircuitBreakerInterceptor.java

@@ -21,7 +21,7 @@
 import org.hypertrace.core.grpcutils.context.RequestContext;
 
 @Slf4j
-public class ResilienceCircuitBreakerInterceptor extends CircuitBreakerInterceptor {
+class ResilienceCircuitBreakerInterceptor extends CircuitBreakerInterceptor {
 
   private final ResilienceCircuitBreakerProvider resilienceCircuitBreakerProvider;
   private final CircuitBreakerConfiguration<?> circuitBreakerConfiguration;