ENG-5066: GuavaCacheMetric Support (#33)

* ENG-5066: GuavaCache Metrics Support

* ENG 5066: GuavaCache Metric Support

* ENG-5066, GuavaCache Metric Support (code formatting fixed)

* ENG-5066: GuavaCacheMetric Support, Fixed test-cases

* ENG 5066: GuavaCacheMetric; Added test for cache size, Better efficient meter access

* ENG 5066: GuavaCacheMetric Support, formatting issues

* ENG 5066: GuavaCacheMetrics, Made comments more verbose

* ENG 5066: GuavaCacheMetrics, Made comments more verbose

* ENG-5066, GuavaCacheMetric Support; Added tags to the cache monitoring meter.

* Formatting issue fixed

* Formatting issues

Co-authored-by: Apoorv Jain <[email protected]>

Author: Apoorv Jain

platform-metrics/src/main/java/org/hypertrace/core/serviceframework/metrics/PlatformMetricsRegistry.java

@@ -380,8 +380,9 @@ public static DistributionSummary registerDistributionSummary(String name,
    * Registers metrics for GuavaCaches using micrometer's GuavaCacheMetrics under the given
    * cacheName for the given guavaCache
    */
-  public static <K, V> void registerCache(String cacheName, Cache<K, V> guavaCache) {
-    GuavaCacheMetrics.monitor(METER_REGISTRY, guavaCache, cacheName);
+  public static <K, V> void registerCache(String cacheName, Cache<K, V> guavaCache, Map<String, String> tags) {
+    GuavaCacheMetrics.monitor(METER_REGISTRY, guavaCache, cacheName, addDefaultTags(tags));
+
   }
 
   /**

platform-metrics/src/test/java/org/hypertrace/core/serviceframework/metrics/PlatformMetricsRegistryTest.java

@@ -164,8 +164,7 @@ public void testDistributionSummary() {
   public void testCache() throws Exception {
     initializeCustomRegistry(List.of("testing"));
     Cache<String, Integer> cache = CacheBuilder.newBuilder().maximumSize(10).recordStats().build();
-
-    PlatformMetricsRegistry.registerCache("my.cache", cache);
+    PlatformMetricsRegistry.registerCache("my.cache", cache, Map.of("foo","bar"));
     Callable<Integer> loader =
         new Callable<Integer>() {
           @Override