Skip to content

Commit 211a287

Browse files
authored
refactor: import exported modules rather files (#394)
* refactor: not import files directly but import exported modules * fix: unique key lost in React component
1 parent 0022263 commit 211a287

8 files changed

Lines changed: 27 additions & 23 deletions

File tree

src/pages/ContentScripts/DeveloperActiInflTrend.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {
88
getMessageByLocale,
99
} from '../../utils/utils';
1010
import PerceptorBase from './PerceptorBase';
11-
import { inject2Perceptor } from './Perceptor';
1211
import Settings, { loadSettings } from '../../utils/settings';
1312
import { getDeveloperActiInfl } from '../../api/developer';
1413
import Bars from '../../components/Bars/index';
@@ -136,4 +135,4 @@ class DeveloperActiInflTrend extends PerceptorBase {
136135
}
137136
}
138137

139-
inject2Perceptor(DeveloperActiInflTrend);
138+
export default DeveloperActiInflTrend;

src/pages/ContentScripts/DeveloperNetwork.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import {
1616
} from '../../api/developer';
1717
import { runsWhen, getMessageByLocale } from '../../utils/utils';
1818
import PerceptorBase from './PerceptorBase';
19-
import { inject2Perceptor } from './Perceptor';
2019
import Settings, { loadSettings } from '../../utils/settings';
2120
import Graph from '../../components/Graph/Graph';
2221
import TeachingBubbleWrapper from './TeachingBubbleWrapper';
@@ -386,4 +385,4 @@ class DeveloperNetwork extends PerceptorBase {
386385
}
387386
}
388387

389-
inject2Perceptor(DeveloperNetwork);
388+
export default DeveloperNetwork;

src/pages/ContentScripts/Hypertrons.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import {
2222
} from '../../services/hypertrons';
2323
import { getMessageByLocale, runsWhen } from '../../utils/utils';
2424
import PerceptorBase from './PerceptorBase';
25-
import { inject2Perceptor } from './Perceptor';
2625
import logger from '../../utils/logger';
2726
import Settings, { loadSettings } from '../../utils/settings';
2827
import { getConfigFromGithub } from '../../api/github';
@@ -206,6 +205,7 @@ const HypertronsTabView: React.FC<HypertronsTabViewProps> = ({
206205
const styleIndex = index % (LabelStyles.length - 1);
207206
return (
208207
<div
208+
key={`command_${index}`}
209209
// @ts-ignore
210210
style={Label2Style(LabelStyles[styleIndex])}
211211
className="IssueLabel hx_IssueLabel"
@@ -260,4 +260,4 @@ class Hypertrons extends PerceptorBase {
260260
}
261261
}
262262

263-
inject2Perceptor(Hypertrons);
263+
export default Hypertrons;

src/pages/ContentScripts/PerceptorLayout.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { render } from 'react-dom';
33
import $ from 'jquery';
44
import { isPerceptor, runsWhen } from '../../utils/utils';
55
import PerceptorBase from './PerceptorBase';
6-
import { inject2Perceptor } from './Perceptor';
76

87
const PerceptorLayoutView: React.FC = () => {
98
return <div />;
@@ -26,4 +25,4 @@ class PerceptorLayout extends PerceptorBase {
2625
}
2726
}
2827

29-
inject2Perceptor(PerceptorLayout);
28+
export default PerceptorLayout;

src/pages/ContentScripts/PerceptorTab.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import * as pageDetect from 'github-url-detection';
33
import { utils } from 'github-url-detection';
44
import { isPerceptor, runsWhen, isPublicRepo } from '../../utils/utils';
55
import PerceptorBase from './PerceptorBase';
6-
import { inject2Perceptor } from './Perceptor';
76
import { render } from 'react-dom';
87
import React from 'react';
98
import TeachingBubbleWrapper from './TeachingBubbleWrapper';
@@ -97,4 +96,4 @@ class PerceptorTab extends PerceptorBase {
9796
}
9897
}
9998

100-
inject2Perceptor(PerceptorTab);
99+
export default PerceptorTab;

src/pages/ContentScripts/ProjectNetwork.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import { isPerceptor, runsWhen } from '../../utils/utils';
1414
import { getRepoCorrelation, getDevelopersByRepo } from '../../api/repo';
1515
import { getMessageByLocale } from '../../utils/utils';
1616
import PerceptorBase from './PerceptorBase';
17-
import { inject2Perceptor } from './Perceptor';
1817
import Settings, { loadSettings } from '../../utils/settings';
1918
import ErrorPage from '../../components/ExceptionPage/ErrorPage';
2019

@@ -282,4 +281,4 @@ class ProjectNetwork extends PerceptorBase {
282281
}
283282
}
284283

285-
inject2Perceptor(ProjectNetwork);
284+
export default ProjectNetwork;

src/pages/ContentScripts/RepoActiInflTrend.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import {
88
getMessageByLocale,
99
} from '../../utils/utils';
1010
import PerceptorBase from './PerceptorBase';
11-
import { inject2Perceptor } from './Perceptor';
1211
import Settings, { loadSettings } from '../../utils/settings';
1312
import { utils } from 'github-url-detection';
1413
import { getRepoActiInfl } from '../../api/repo';
@@ -156,4 +155,4 @@ class RepoActiInflTrend extends PerceptorBase {
156155
}
157156
}
158157

159-
inject2Perceptor(RepoActiInflTrend);
158+
export default RepoActiInflTrend;

src/pages/ContentScripts/index.ts

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,26 @@
22
import { initializeIcons } from '@fluentui/react/lib/Icons';
33
initializeIcons();
44

5-
import './DeveloperActiInflTrend';
6-
import './RepoActiInflTrend';
7-
import './PerceptorTab';
8-
import './PerceptorLayout';
9-
import './DeveloperNetwork';
10-
import './ProjectNetwork';
11-
import './Hypertrons';
12-
import './content.styles.css';
13-
import { Perceptor } from './Perceptor';
145
import { loadSettings } from '../../utils/settings';
6+
import { inject2Perceptor, Perceptor } from './Perceptor';
7+
8+
import DeveloperActiInflTrend from './DeveloperActiInflTrend';
9+
import RepoActiInflTrend from './RepoActiInflTrend';
10+
import PerceptorTab from './PerceptorTab';
11+
import PerceptorLayout from './PerceptorLayout';
12+
import DeveloperNetwork from './DeveloperNetwork';
13+
import ProjectNetwork from './ProjectNetwork';
14+
import Hypertrons from './Hypertrons';
15+
16+
import './content.styles.css';
17+
18+
inject2Perceptor(DeveloperActiInflTrend);
19+
inject2Perceptor(RepoActiInflTrend);
20+
inject2Perceptor(PerceptorTab);
21+
inject2Perceptor(PerceptorLayout);
22+
inject2Perceptor(DeveloperNetwork);
23+
inject2Perceptor(ProjectNetwork);
24+
inject2Perceptor(Hypertrons);
1525

1626
async function mainInject() {
1727
const settings = await loadSettings();

0 commit comments

Comments
 (0)