feat: Migrate to Hardhat 3 #312
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, and WorkerpoolRegistry for enhanced deployment handling
…y documentation for Iexec interfaces and methods
…f JSON files and updating initialization logic in Registry contract
…y documentation for new methods in Iexec contracts
…acet to prevent underflow and ensure backward compatibility
…y documentation for Iexec contracts
…statements in test files for consistency
Co-authored-by: Copilot <[email protected]>
…ub.com/iExecBlockchainComputing/PoCo into feature/make-v8-migration-non-breaking
…ns and adding new contract interfaces for improved clarity and organization
…rations for enhanced security in maintenance tasks
… proper formatting
…functions for improved readability
…improved error handling
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
… storing account balance in a variable
… adding new escrow facets
…ying balance retrieval
…to streamline deployment by consolidating migration checks into _mintCreate function. This change enhances backward compatibility and prepares for future updates.
…aset structures, update function signatures, and enhance clarity by removing outdated interfaces. This update includes the addition of new methods for managing categories, datasets, and worker pools, ensuring better organization and maintainability.
…consistency across multiple contracts
…nd organization, consolidating interfaces and updating function signatures for improved readability
…ing in IexecERC20Core contract for better readability and maintainability
…solidate function signatures, and enhance clarity by introducing new methods for managing categories, datasets, and worker pools. This update also includes breaking changes to improve organization and maintainability.
…ate package.json to exclude TimelockController from build artifacts
…ry structure, consolidate interfaces, and enhance function signatures for better clarity and organization. This update includes breaking changes and new methods for managing categories, datasets, and worker pools.
…0.10, add old config file for reference, and update Node version in .nvmrc
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from CommonJS to ES Modules (ESM) and upgrades Hardhat from version 2 to version 3. The configuration has been significantly simplified while maintaining core functionality.
Key changes:
- Package.json now declares
"type": "module"to enable ESM - Hardhat upgraded from v2.22.18 to v3.0.10
- Node.js version updated from 20 to 22.10.0
- Direct module execution check updated from CommonJS pattern to ESM-compatible approach
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Declares ESM mode, upgrades Hardhat to v3, removes incompatible toolbox dependency |
| hardhat.config.ts | Drastically simplified configuration, removing most network/task definitions (likely moved elsewhere) |
| hardhat.config.old.ts | Preserves previous configuration with Hardhat 3 adaptations for reference |
| scripts/tools/copy-deployments.ts | Updates direct execution check from CommonJS to ESM pattern |
| .nvmrc | Specifies Node.js 22.10.0 for version management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // When script is run directly | ||
| if (require.main === module) { | ||
| // When script is run directly (ESM compatible check) | ||
| if (import.meta.url === `file://${process.argv[1]}`) { |
There was a problem hiding this comment.
The ESM direct execution check is incorrect. process.argv[1] contains an absolute file path, but import.meta.url is a file:// URL. On Windows, this comparison will fail due to path separator differences. Use import.meta.url === pathToFileURL(process.argv[1]).href with import { pathToFileURL } from 'url'; instead.
| }, | ||
| }, | ||
| }; | ||
| import type { HardhatUserConfig } from 'hardhat/config'; |
There was a problem hiding this comment.
The drastically simplified configuration is missing plugin imports (hardhat-deploy, hardhat-dependency-compiler, solidity-docgen, dotenv/config) and all custom tasks that were present in the original. While hardhat.config.old.ts preserves the full configuration, ensure these are intentionally removed or relocated, as this will break existing workflows.
…endency compiler and solidity docgen, and add new ABI exporter settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardhat Migration Guide
État de la migration Hardhat 3
✅ Fait
^2.22.18→^3.0.10package.json: ajout"type": "module"(ESM requis)hardhat.config.tsavec seulementsolidityconfighardhat.config.old.ts.nvmrcmodifié avec Node.js 22.10.0Plugins non compatibles (à migrer/remplacer)
hardhat-deploy(^0.11.43)Package subpath './types/runtime' is not definedhardhat-dependency-compiler(^1.2.1)Package subpath './builtin-tasks/task-names' is not defined@nomicfoundation/hardhat-toolbox(retiré)package.json@nomicfoundation/hardhat-toolbox-mocha-etherspour les tests (voir guide)solidity-docgen(^0.6.0-beta.36)ERR_REQUIRE_ESMsolidity-coverage(^0.8.14)📋 À faire
Migration de la configuration (depuis
hardhat.config.old.ts)networks) avectype: 'http'outype: 'edr-simulated'abis,docgen,test)namedAccounts(si supporté par hardhat-deploy v3)etherscanetsourcifytypechainconfigmochaconfigPlugins et tests
@nomicfoundation/hardhat-toolbox-mocha-etherspour les testsdeploy/) pour fonctionner sans hardhat-deploy ou avec alternativesolidity-coveragecompatibilitésolidity-docgenune fois compatibleDépendances externes
hardhat-dependency-compilerquand compatiblehardhat-deployquand compatible@mudgen/diamond-1avec Hardhat 3