Skip to content

Commit 6b7c6d4

Browse files
MehediiamMehedi
authored andcommitted
generated interfaces doesn't need to be public.
1 parent 0e1d9e4 commit 6b7c6d4

3 files changed

Lines changed: 16 additions & 3 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ StepBuilder Generator
55
plugin that adds a 'Step Builder' action to the Generate menu (Alt+Insert)
66
which generates a Builder class which follows the Step Builder pattern. You can
77
read about the Step Builder pattern and why it might be a little more effective than
8-
the usual Builder pattern [here](http://www.jayway.com/2012/02/07/builder-pattern-with-a-twist/).
8+
the usual Builder pattern [here](http://devliving.online/stepbuilder-builder-that-guides-you-through-the-steps/).
99

1010
![screenshot](screenshot_1.png)
1111

resources/META-INF/plugin.xml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<idea-plugin version="2">
22
<id>online.devliving.stepbuilder.generator</id>
33
<name>StepBuilder Generator</name>
4-
<version>1.0</version>
4+
<version>1.0.1</version>
55
<vendor email="mehedi@devliving.online" url="http://www.devliving.online">Mehedi Hasan Khan</vendor>
66

77
<description><![CDATA[
@@ -127,6 +127,11 @@
127127
<td> 1.0.0</td>
128128
<td>First release</td>
129129
</tr>
130+
131+
<tr>
132+
<td> 1.0.1</td>
133+
<td>Generated interfaces aren't public</td>
134+
</tr>
130135
</table>
131136
]]>
132137
</change-notes>

src/online/devliving/stepbuilder/generator/StepBuilderGenerator.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,12 @@ public void run() {
213213
}
214214

215215
private PsiClass createBuildStepInterface(){
216-
return psiElementFactory.createInterface(INTERFACE_NAME_PREFIX + BUILD_STEP_INTERFACE_NAME);
216+
PsiClass buildStep = psiElementFactory.createInterface(INTERFACE_NAME_PREFIX + BUILD_STEP_INTERFACE_NAME);
217+
if(buildStep.getModifierList() != null){
218+
buildStep.getModifierList().setModifierProperty(PsiModifier.PUBLIC, false);
219+
}
220+
221+
return buildStep;
217222
}
218223

219224
/**
@@ -229,6 +234,9 @@ private PsiClass generateMandatoryInterface(PsiFieldMember forMember, PsiType re
229234
BUILDER_SETTER_ALTERNATIVE_PARAMETER_NAME:BUILDER_SETTER_DEFAULT_PARAMETER_NAME;
230235

231236
PsiClass mInterface = psiElementFactory.createInterface(INTERFACE_NAME_PREFIX + capitalizedFieldName);
237+
if(mInterface.getModifierList() != null){
238+
mInterface.getModifierList().setModifierProperty(PsiModifier.PUBLIC, false);
239+
}
232240

233241
PsiMethod fieldMethod = psiElementFactory.createMethodFromText(String.format("%s %s(%s %s);", returnType.getPresentableText(),
234242
methodName, forMember.getElement().getType().getPresentableText(), paramName), mInterface);

0 commit comments

Comments
 (0)