Drop db_sql_render method?

[hadley]

dbplyr now automatically drops ORDER BY from subqueries, so I don't think you need this any more, and I think you're the only user of the generic, which means I could (eventually) drop it from dbplyr.

[ianmcook]

That's great; thanks for notifying me! I will plan to remove this method when I implement other changes soon to ensure continued compatibility with dbplyr .

[ianmcook]

Based on tidyverse/dbplyr#501, it looks like dbplyr now also issues a warning when it drops the ORDER BY in a subquery. This is great—thank you @hadley! Previously dbplyr did not issue a warning in this situation. In the specific case of Impala, I felt it was important to warn users when they used the arrange() verb in a way that would ultimately be ignored by Impala. Hence I made implyr detect this condition and issue a warning (but not actually drop the ORDER BY clause). I believe dbplyr now solves this whole problem upstream of implyr.

[hadley]

BTW I don't yet solve #30 (because it turns out that I fundamentally misunderstood the grammar for UNION and friends), but you're welcome to file it in dbplyr and I'll tackle it in a future release.