Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-inlined sourcemaps don't load #40

Open
ianstormtaylor opened this issue Dec 2, 2022 · 0 comments
Open

Non-inlined sourcemaps don't load #40

ianstormtaylor opened this issue Dec 2, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@ianstormtaylor
Copy link
Owner

ianstormtaylor commented Dec 2, 2022

Because the entrypoint server is really simple currently, and just serves sketch.js and sketch.js.map, if any of the imported packages in a sketch don't include their sourceContent inline in the sourcemap, they won't be able to be loaded by devtools.

In TypeScript a third-party package can make its source content inlined by setting…

{
    "sourceMap": true,
    "inlineSources": true,
}

…but many won't have done that.

Ideally either the server could serve all files (need to check if this is secure first though). Or the single sourcemap could get all of its source files's content inlined, and its JSON can be updated with the new source content strings before serving.

@ianstormtaylor ianstormtaylor added the bug Something isn't working label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant