Fixed method call to getFieldTypeIdentifier in acceptsFieldDefinition for improved clarity

tbialcz · tbialcz · commit 6409736cacd5 · 2025-08-25T08:58:40.000+02:00
diff --git a/src/lib/Form/Type/Extension/EventSubscriber/ModifyFieldDefinitionFieldsSubscriber.php b/src/lib/Form/Type/Extension/EventSubscriber/ModifyFieldDefinitionFieldsSubscriber.php
@@ -110,7 +110,7 @@ private function getContentTypeDraft(array $data): ?ContentTypeDraft
 
     private function acceptsFieldDefinition(FieldDefinitionData $field, string $identifier): bool
     {
-        $matchesType = $this->fieldTypeIdentifier === $field->fieldDefinition->fieldTypeIdentifier;
+        $matchesType = $this->fieldTypeIdentifier === $field->getFieldTypeIdentifier();
         $matchesIdentifier = in_array($identifier, $this->fieldIdentifiers, true);
 
         return $matchesType || $matchesIdentifier;

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ private function getContentTypeDraft(array $data): ?ContentTypeDraft`
`110`	`110`
`111`	`111`	`private function acceptsFieldDefinition(FieldDefinitionData $field, string $identifier): bool`
`112`	`112`	`{`
`113`		`- $matchesType = $this->fieldTypeIdentifier === $field->fieldDefinition->fieldTypeIdentifier;`
	`113`	`+ $matchesType = $this->fieldTypeIdentifier === $field->getFieldTypeIdentifier();`
`114`	`114`	`$matchesIdentifier = in_array($identifier, $this->fieldIdentifiers, true);`
`115`	`115`
`116`	`116`	`return $matchesType \|\| $matchesIdentifier;`