IBX-9838: Fixed edit option in three-dot menu remains clickable despite insufficient user permissions (#1525)

* fixed edit permission check

* implemented suggested changes

* small refactor of initial fix

* phpstan fix

Author: Sztig

src/bundle/Controller/Content/ContentTreeController.php

@@ -49,7 +49,7 @@ class ContentTreeController extends RestController
 
     private ConfigResolverInterface $configResolver;
 
-    private SiteaccessResolverInterface  $siteaccessResolver;
+    private SiteaccessResolverInterface $siteaccessResolver;
 
     public function __construct(
         LocationService $locationService,
@@ -226,7 +226,7 @@ private function getLocationPermissionRestrictions(Location $location): array
                 'restrictedLanguageCodes' => $createLimitationsValues[Limitation::LANGUAGE],
             ],
             'edit' => [
-                'hasAccess' => $lookupUpdateLimitationsResult->hasAccess(),
+                'hasAccess' => $this->canUserEditContent($location),
                 // skipped content type limitation values as in this case it can be inferred from "hasAccess" above
                 'restrictedLanguageCodes' => $updateLimitationsValues[Limitation::LANGUAGE],
             ],
@@ -325,6 +325,20 @@ private function isPreviewable(
 
         return !empty($siteAccesses);
     }
+
+    /**
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\BadStateException
+     * @throws \Ibexa\Contracts\Core\Repository\Exceptions\InvalidArgumentException
+     */
+    private function canUserEditContent(Location $location): bool
+    {
+        return $this->permissionResolver->canUser(
+            'content',
+            'edit',
+            $location->getContent(),
+            [$location]
+        );
+    }
 }
 
 class_alias(ContentTreeController::class, 'EzSystems\EzPlatformAdminUiBundle\Controller\Content\ContentTreeController');

src/bundle/Controller/ContentController.php

@@ -216,6 +216,7 @@ public function proxyCreateAction(
     public function editAction(Request $request): Response
     {
         /* @todo it shouldn't rely on keys from request */
+        /** @var string[] $requestKeys */
         $requestKeys = $request->request->keys();
         $formName = $request->query->get(
             'formName',