New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: standardize _in_memory_table_exists #10123

Open

ncclementi opened this issue Sep 13, 2024 · 0 comments

Milestone

Contributor

ncclementi commented Sep 13, 2024 •

edited

Loading

I saw this comment #10067 (review) from @jcrist and I'm converting it into an issue so we don't loose track of it.

Where is suggested to change the default implementation to:

try:
    self.table(name)
    return True
except TableNotFound:
    return False

This #9695 was merged
I'm not sure about the details of the implementation/refactor but this seems like it could be a nice consolidation of code

gforsyth added this to the 10.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment