bench: add spdlog mt benchmark

Author: iboB

bench/b-vs-spdlog.cpp

@@ -5,16 +5,22 @@
 
 #include "BenchSink.hpp"
 
+#include <jalog/Instance.hpp>
 #include <jalog/Logger.hpp>
 #include <jalog/Scope.hpp>
 #include <jalog/Log.hpp>
 
 #include <spdlog/spdlog.h>
 #include <spdlog/logger.h>
+#include <spdlog/async_logger.h>
+#include <spdlog/async.h>
 #include <spdlog/sinks/base_sink.h>
 
 #include <picobench/picobench.hpp>
 
+#include <thread>
+#include <mutex>
+
 constexpr jalog::Level lcvt(spdlog::level::level_enum spdl) {
     using namespace spdlog::level;
     using jalog::Level;
@@ -30,9 +36,10 @@ constexpr jalog::Level lcvt(spdlog::level::level_enum spdl) {
     }
 }
 
-class SpdlogHashingSink : public spdlog::sinks::base_sink<spdlog::details::null_mutex> {
+template <typename Mutex>
+class SpdlogHashingSink : public spdlog::sinks::base_sink<Mutex> {
     size_t m_digest = 0;
-public:
+
     void sink_it_(const spdlog::details::log_msg& msg) override {
         size_t d = 0;
         BenchSink::hashAppend(d,
@@ -45,7 +52,7 @@ class SpdlogHashingSink : public spdlog::sinks::base_sink<spdlog::details::null_
         m_digest ^= d;
     }
     void flush_() override {}
-
+public:
     size_t digest() const {
         return m_digest;
     }
@@ -54,7 +61,8 @@ class SpdlogHashingSink : public spdlog::sinks::base_sink<spdlog::details::null_
     }
 };
 
-#include <jalog/LogPrintf.hpp>
+PICOBENCH_SUITE("single thread");
+
 void jalog_log(picobench::state& s) {
     jalog::Logger jl;
     auto sink = std::make_shared<BenchSink>();
@@ -69,7 +77,7 @@ void jalog_log(picobench::state& s) {
 PICOBENCH(jalog_log);
 
 void spdlog_log(picobench::state& s) {
-    auto sink = std::make_shared<SpdlogHashingSink>();
+    auto sink = std::make_shared<SpdlogHashingSink<spdlog::details::null_mutex>>();
     spdlog::logger spdl("hi", {sink});
 
     for (auto i : s) {
@@ -78,3 +86,65 @@ void spdlog_log(picobench::state& s) {
     s.set_result(sink->digest());
 }
 PICOBENCH(spdlog_log);
+
+PICOBENCH_SUITE("multi thread");
+
+constexpr size_t Num_Threads = 4;
+
+void jalog_mt(picobench::state& s) {
+    jalog::Logger jl;
+    auto sink = std::make_shared<BenchSink>();
+    jalog::Scope scope{jl, "mt"};
+    jalog::Instance inst(jl);
+    inst.setup().async().add(sink);
+
+    const int num_msg = s.iterations();
+
+    std::vector<std::thread> threads;
+    threads.reserve(Num_Threads);
+
+    {
+        picobench::scope bench(s);
+
+        for (size_t i = 0; i < Num_Threads; ++i) {
+            threads.emplace_back([i, &scope, &num_msg]() {
+                for (int imsg = 0; imsg < num_msg; ++imsg) {
+                    JALOG_SCOPE(scope, Info, "Thread ", i, " msg ", imsg);
+                }
+            });
+        }
+        for (auto& t : threads) t.join();
+    }
+
+    jl.flush();
+    s.set_result(sink->digest());
+}
+PICOBENCH(jalog_mt);
+
+void spdlog_mt(picobench::state& s) {
+    auto sink = std::make_shared<SpdlogHashingSink<std::mutex>>();
+    spdlog::init_thread_pool(s.iterations(), 1);
+    auto logger = std::make_shared<spdlog::async_logger>("mt", sink, spdlog::thread_pool());
+
+    const int num_msg = s.iterations();
+
+    std::vector<std::thread> threads;
+    threads.reserve(Num_Threads);
+
+    {
+        picobench::scope bench(s);
+        for (size_t i = 0; i < Num_Threads; ++i) {
+            threads.emplace_back([i, &logger, &num_msg]() {
+                for (int imsg = 0; imsg < num_msg; ++imsg) {
+                    logger->info("Thread {} msg {}", i, imsg);
+                }
+            });
+        }
+        for (auto& t : threads) t.join();
+    }
+
+    logger->flush();
+    spdlog::shutdown();
+    s.set_result(sink->digest());
+}
+PICOBENCH(spdlog_mt);

bench/picobench-main.cpp

@@ -6,7 +6,7 @@ int main(int argc, char* argv[])
     picobench::runner r;
     r.set_compare_results_across_samples(true);
     r.set_compare_results_across_benchmarks(true);
-    r.set_default_state_iterations({15024});
+    r.set_default_state_iterations({100'000});
     r.parse_cmd_line(argc, argv);
     return r.run();
 }

bench/t-BenchSink.cpp

@@ -28,6 +28,12 @@ TEST_CASE("bench sink") {
 
     CHECK(d == sink->reset());
 
+    // check that order doesn't mg
+    JALOG_SCOPE(scope, Debug, "bar");
+    JALOG_SCOPE(scope, Info, "foo");
+
+    CHECK(d == sink->reset());
+
     JALOG_PRINTF_SCOPE(scope, Info, "foo");
     JALOG_PRINTF_SCOPE(scope, Debug, "bar");