Mh/#1275 new copy builders #1277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should i remove some of the getters and/or setters here or keep them all in? Or did the Quality gate fail because of another reason here? @staudtMarius |
|
@marvinheintze I think the best would be, to just add some test for these copy builders. You could place the tests in the same files as the other test of these type inputs. |
staudtMarius
requested changes
Mar 20, 2025
src/main/java/edu/ie3/datamodel/models/input/connector/type/LineTypeInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/connector/type/LineTypeInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/connector/type/Transformer2WTypeInput.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/connector/type/Transformer3WTypeInput.java
Show resolved
Hide resolved
|
@marvinheintze I check the other copy builders. It seems like the naming convention is, to use the name of the value as the name the method of the copy builder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1275
Added CopyBuilders to LineTypeInput, Transformer2WTypeInput, Transformer3WTypeInput similar to the one from SystemParticipantTypeInput