-
Notifications
You must be signed in to change notification settings - Fork 0
Hotfix: Issues with custom pipelines #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kels271828
wants to merge
31
commits into
release/1.1
Choose a base branch
from
hotfix/custom_pipeline_issues
base: release/1.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture/jobmon_workflow_passthrough
Member
Author
|
I wasn't sure where this fix would go (i.e., 1.0.4 vs. 1.1.1), so I haven't updated the version/changelog/etc. Also still working on tests. |
blsmxiu47
reviewed
Mar 19, 2025
zhengp0
reviewed
Mar 20, 2025
…through Add Jobmon workflow passthrough via `add_tasks_to_workflow`, as well as some Jobmon related args
Fix failing tests
Member
Author
|
Pulling into |
…nto hotfix/custom_pipeline_issues
blsmxiu47
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Fixed issues related to custom
PipelineandConfigclasses when reloading from JSON files.WHY
Pipelineclass; would be missing any custom fields or methods and config would not be validatedConfigclass in the stage config; pipeline config fields would not be validatedHOW
pipeline.py:typeandmoduleattributes toPipeline__init__()function toPipelinemain.py:_get_stage()and_get_custom_stage()methods to work with stages and pipelines; renamed to_get_class()and_get_custom_class()load_pipelineto use_get_class()function rather than returning a basePipelineobjectconfig.py: Infer type of_pipeline_configrather than using a baseConfigobjectadvanced_usage.rst: Updated documentation related to customConfigandStageConfigclasses