Skip to content

Commit 5f5a308

Browse files
authored
Merge pull request #107 from ikalnytskyi/bug/skip-asgi-websocket-on-pypy
Skip ASGI websocket tests on PyPy
2 parents 792f03e + f10cd09 commit 5f5a308

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@ jobs:
3535
matrix:
3636
os: [ubuntu-latest, macos-latest]
3737
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13", "pypy-3.10"]
38-
exclude:
39-
# The job hangs for some reason during tests execution. :(
40-
- os: macos-latest
41-
python-version: pypy-3.10
4238

4339
runs-on: ${{ matrix.os }}
4440
steps:

tests/ext/test_asgiscopes.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
"""Test ASGI scopes."""
22

33
import asyncio
4+
import sys
45

56
import async_asgi_testclient
67
import pytest
@@ -98,6 +99,9 @@ async def endpoint_ws(websocket, func=func):
9899
def client_factory(connection_type):
99100
"""A factory that creates synchronous test client instances."""
100101

102+
if connection_type == "websocket" and sys.implementation.name == "pypy":
103+
pytest.skip("When running on PyPy, the websocket tests sometimes hang.")
104+
101105
def factory(app):
102106
return ClientFacade(app, connection_type)
103107

0 commit comments

Comments
 (0)