Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chunked requests: use "Expect: 100-continue" header and improve error handling #120

Open
jfacorro opened this issue Nov 19, 2015 · 0 comments
Labels

Comments

@jfacorro
Copy link
Contributor

The current approach is not very sound since it only contemplates the "happy path". Failed requests such as 4XX and 5XX should be returned immediately when trying to do a chunked request.

Using the header Expect: 100-continue forces the server to send an initial 100 (Continue) status when the request is successful and an additional final status when the request body is fully sent (HTTP Specs). We can return the initial 100 to the user and the final status when all the body chunks are sent.

jfacorro added a commit that referenced this issue Nov 19, 2015
@jfacorro jfacorro changed the title Chunked requests: use "Expect: 100-conitnue" header and improve error handling Chunked requests: use "Expect: 100-continue" header and improve error handling Nov 19, 2015
@jfacorro jfacorro added the bug label Nov 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant