fix: modify cache key when per_page is zero, WEB-889 (#556)

Author: pleary

lib/util.js

@@ -430,7 +430,8 @@ const util = class util {
     cacheableParams.qualityGrade = queryDup.quality_grade ? queryDup.quality_grade : null;
     cacheableParams.spam = queryDup.spam ? queryDup.spam : null;
     cacheableParams.captive = queryDup.captive ? queryDup.captive : null;
-    cacheableParams.perPage = queryDup.per_page ? queryDup.per_page : null;
+    cacheableParams.perPage = ( _.isNumber( queryDup.per_page ) || queryDup.per_page )
+      ? queryDup.per_page : null;
     cacheableParams.order = queryDup.order ? queryDup.order : null;
     cacheableParams.orderBy = queryDup.order_by ? queryDup.order_by : null;
     cacheableParams.returnBounds = queryDup.return_bounds ? queryDup.return_bounds : null;

test/util.js

@@ -194,6 +194,10 @@ describe( "util", ( ) => {
       expectParamInCacheKey( "place_id", 1, "placeID" );
     } );
 
+    it( "allows queries with numeric per_page value of 0 to be cached for obs search", ( ) => {
+      expectParamInCacheKey( "per_page", 0, "perPage" );
+    } );
+
     it( "does not allow queries with place_id to be cached for obs search when logged in", ( ) => {
       const req = {
         query: {